Repository navigation
Firewall security profiles 2026 05 01 - #47827
Ben Eshed (bewatersmsft) wants to merge 1 commit into
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
Other outstanding requirements (4)
Comment generated by summarize-checks workflow run. |
|
Was already signed off here, but missed the cut for 2026-03-01 |
TypeSpec suppressions requiring reviewStatus: ❌ Approval required — 2 suppressions This PR adds or updates the TypeSpec suppressions listed below. Suppressions are strongly discouraged — they bypass linter rules that protect API quality and consistency. Authors should avoid adding new suppressions and prefer fixing the underlying issue; reviewers should approve only when there is a clear, compelling justification and no reasonable alternative. Review each linked rule and source location, then apply New suppressions (2)
For an overview of TypeSpec linting rules click here. 💬 Have feedback on the TypeSpec suppression flow? Let us know. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
Comment generated by After APIView workflow run. |
ARM API Review SummaryReviewed PR #47827 at head SHA Approval labels observed:
No issues found. The full review covered the added FirewallPolicy security profile and security profile group resources, generated OpenAPI, versioning, LRO metadata, discriminated schemas, examples, and existing discussion; the independent Critic verified the no-findings result. posted-by: arm-api-reviewer-agent | rule: summary | category: summary | severity: suggestion | classification: new | critic: pass | head-sha: 84efd5a
|
There was a problem hiding this comment.
ARM API Review
Reviewed the full PR at head SHA 84efd5a4ea3f5102f517a0639f0a422d4e5b46f4. No actionable ARM/API findings were identified. The independent Critic verified the child-resource paths and parent metadata, CRUD/LIST coverage, pageable and long-running-operation metadata, discriminated schemas, required fields, ARM identifiers, versioning, examples, URL and managed-identity fields, suppression justifications, and preservation of the existing signatureOverrides surface.
posted-by: arm-api-reviewer-agent | rule: summary | category: summary | severity: suggestion | classification: new | critic: pass | head-sha: 84efd5a
🔍 ARM API review by ARM API Review: Automated Workflow
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.