Repository navigation
Reject JavaScript and TypeScript files in service folders - #47826
Merged
Timothee Guerin (timotheeguerin) merged 5 commits intoNov 3, 2026
Merged
Timothee Guerin (timotheeguerin) merged 5 commits into
Timothee Guerin (timotheeguerin) merged 5 commits into
Conversation
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.Comment generated by summarize-checks workflow run. |
Timothee Guerin (timotheeguerin)
changed the title
Timothee Guerin (timotheeguerin)
marked this pull request as ready for review
November 3, 2026 13:36
Timothee Guerin (timotheeguerin)
requested review from
a team,
Mary Gao (MaryGao),
Qiaoqiao Zhang (qiaozha) and
Ray Chen (raych1)
as code owners
November 3, 2026 13:36
Timothee Guerin (timotheeguerin)
deleted the
timotheeguerin/block-specification-scripts
branch
November 3, 2026 13:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Service folders should contain API descriptions, not JavaScript or TypeScript implementations. For example, #47311 includes
specification/webpubsub/data-plane/WebPubSubChat/client-customizations.mjs, which should fail TypeSpec Validation.Add a normal TSV
DisallowedFileTypesrule that recursively scansspecification/<service>/, including shared files, sibling projects, and hidden files. It checks the current filesystem in single-project,--all, and--changedvalidation, without comparing Git revisions. Installednode_modulesand.gitdirectories are excluded. The initial extension denylist covers JavaScript and TypeScript variants and can be extended to other file types later.Exact-file suppressions in
specification/suppressions.yamlgrandfather the five existing.mjsfiles: the Foundry voice-event emitter and its test, plus three Cognitive Services contract tests. New scripts in those services still fail; there are no blanket service exemptions. These exceptions can be removed as the existing tooling is relocated.