Fix metrics-sourcer crash loop by cleaning up orphaned telegraf unit - #2206
Open
Narine Mossikyan (NarineM) wants to merge 1 commit into
Open
Fix metrics-sourcer crash loop by cleaning up orphaned telegraf unit#2206Narine Mossikyan (NarineM) wants to merge 1 commit into
Narine Mossikyan (NarineM) wants to merge 1 commit into
Conversation
Siddhartha Mathiharan (simathih)
requested changes
Aug 29, 2026
| def stop_metrics_process(): | ||
|
|
||
| if telhandler.is_running(is_lad=False): | ||
| if telhandler.is_running(is_lad=False) or is_telegraf_service_installed(): |
Collaborator
There was a problem hiding this comment.
maybe check if its enabled as well right?
Collaborator
There was a problem hiding this comment.
- sajithmuh Niamh Gowran (@ngowran) Mikhail Yakshin (@GreyCat) as well to review
Contributor
Author
There was a problem hiding this comment.
metrics-sourcer is never [systemctl enabled (only restarted), so an enabled-check wouldn't gate anything — the crash loop comes from the leftover unit file + Restart=on-failure + the health-check restart, independent of enablement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.