Skip to content

moving Debug invocation logs to Trace - #12019

Open
Brett Samblanet (brettsam) wants to merge 1 commit into
devfrom
brettsam-invocation-response-trace-logging
Open

moving Debug invocation logs to Trace#12019
Brett Samblanet (brettsam) wants to merge 1 commit into
devfrom
brettsam-invocation-response-trace-logging

Conversation

@brettsam

@brettsam Brett Samblanet (brettsam) commented Sep 11, 2026

Copy link
Copy Markdown
Member

Moving two unnecessary Debug logs to Trace. This will improve hot-path logging levels and reduce logs in our backend systems.

Took this opportunity to swap these logs to source-generated logging as well.

Pull request checklist

IMPORTANT: Currently, changes must be backported to the in-proc branch to be included in Core Tools and non-Flex deployments.

  • Backporting to the in-proc branch is not required
    • Otherwise: Link to backporting PR
  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • My changes do not require diagnostic events changes
    • Otherwise: I have added/updated all related diagnostic events and their documentation (Documentation issue linked to PR)
  • I have added all required tests (Unit tests, E2E tests)

@brettsam
Brett Samblanet (brettsam) requested a review from a team as a code owner September 11, 2026 20:40
Copilot AI lite review requested due to automatic review settings September 11, 2026 20:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The focused logging changes are covered by tests and have no unresolved blocking issues.

Pull request overview

Moves hot-path worker-channel logs from Debug to Trace and converts them to source-generated logging.

Changes:

  • Updates relevant logging levels and implementations.
  • Adds tests for Trace levels and event metadata.
File summaries
File Description
test/WebJobs.Script.Tests/Workers/Rpc/GrpcWorkerChannelTests.cs Verifies Trace levels and event metadata.
src/WebJobs.Script.Grpc/Channel/WorkerChannel.cs Updates worker-channel logging behavior and definitions.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants