Skip to content

Skip CLI E2E on drafts with a pipeline guard #4706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mokagio wants to merge 1 commit into
base: trunk
Choose a base branch
from
Draft

Skip CLI E2E on drafts with a pipeline guard #4706

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .buildkite/pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,9 @@ steps:
DEBUG: "pw:browser"
if: (build.branch == 'trunk' || build.tag =~ /^v[0-9]+/ || !build.pull_request.draft) && !(build.pull_request.labels includes 'native-php')

# No `if:` guard: a required status check must report on every build, or PRs
# that skip it hang waiting for it. Doc-only PRs exit early but still report.
# The `if:` guards below stop the required `CLI E2E Tests` status reporting on
# drafts, which is only safe while draft-ness is the condition: a PR has to be
# marked ready to merge, and that transition builds again and reports.
- group: CLI E2E Tests
key: cli-e2e-tests
notify:
Expand All @@ -150,6 +151,7 @@ steps:
matrix:
- mac
- windows
if: build.branch == 'trunk' || build.tag =~ /^v[0-9]+/ || !build.pull_request.draft

# Separate from the matrix above: Mac and Windows share queue/plugin
# defaults that Linux doesn't. Same pattern as the unit-test group.
Expand All @@ -164,6 +166,7 @@ steps:
image: "$NODE_DOCKER_IMAGE"
propagate-environment: true
mount-buildkite-agent: true
if: build.branch == 'trunk' || build.tag =~ /^v[0-9]+/ || !build.pull_request.draft

- label: ":chart_with_upwards_trend: Performance Metrics"
key: metrics
Expand Down