fix(harper.js): slow message passing from slow cache lookups#3588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #3577
Description
This PR fixes a
WorkerLinterperformance regression that affected integrations using inlined WASM binaries, including the Obsidian plugin.SuperBinaryModule.getBinaryModule()now reuses the existing lazyBinaryModuleImpl.innerpromise instead of calling back intoloadBinary(...)on every access. This avoids repeatedly constructing a new cache key from the full inlined WASM data URL, which is very large forslimBinaryInlined.This construction and subsequent comparison was really slow and it was happening every time a message was passed between the
WorkerLinterand the main thread. This resulted in large, noticeable, and persistent lag.How Has This Been Tested?
Manually
AI Disclosure
If Your PR Implements or Enhances a Linter
N/A
Checklist