Skip to content

feat: impressed of→impressed by/with#3566

Open
hippietrail wants to merge 2 commits into
Automattic:masterfrom
hippietrail:impressed-of
Open

feat: impressed of→impressed by/with#3566
hippietrail wants to merge 2 commits into
Automattic:masterfrom
hippietrail:impressed-of

Conversation

@hippietrail
Copy link
Copy Markdown
Collaborator

Issues

N/A

Description

I thought I heard somebody say "impressed of" instead of the usual "impressed by" or "impressed with" in a YouTube video.
Even if he didn't and was just a bit unclear, it turns out to be quite a common mistake.

How Has This Been Tested?

cargo test

AI Disclosure

  • I am a human and didn't use any AI.
  • I used LLM features of my editor, but not an agent.
  • I used an AI agent interactively.
  • I am an agent or I got an agent to do the work autonomously.

If Your PR Implements or Enhances a Linter

  • I made up the sentences in the unit tests.
  • The sentences in the unit tests were generated by an AI.
  • I'm using examples from the bug report / feature request.
  • I collected real-world sentences for the unit tests.

Checklist

  • I have performed a self-review of my own code
  • I have added tests to cover my changes
  • I have considered splitting this into smaller pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant