Add version numbers next to key integrations that are often not up-to-date with the GitHub version #3553
+129
−10
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| import { writable } from 'svelte/store'; | ||
|
|
||
| export const liveVersions = writable<Record<string, string>>({ | ||
| firefox: '', | ||
| js: '', | ||
| rust: '', | ||
| vscode: '', | ||
| }); | ||
|
|
||
| export async function loadLiveVersions() { | ||
| // 1. Firefox Addon | ||
| try { | ||
| const ver = ( | ||
| await ( | ||
| await fetch( | ||
| 'https://addons.mozilla.org/api/v5/addons/addon/private-grammar-checker-harper/', | ||
| ) | ||
| ).json() | ||
| ).current_version.version; | ||
| liveVersions.update((v) => ({ ...v, firefox: ver })); | ||
| } catch {} | ||
|
|
||
| // 2. JS Package | ||
| try { | ||
| const ver = (await (await fetch('https://registry.npmjs.org/harper.js')).json())['dist-tags'] | ||
| .latest; | ||
| liveVersions.update((v) => ({ ...v, js: ver })); | ||
| } catch {} | ||
|
|
||
| // 3. Rust Crate | ||
| try { | ||
| const lines = (await (await fetch('https://index.crates.io/ha/rp/harper-core')).text()).split( | ||
| '\n', | ||
| ); | ||
| liveVersions.update((v) => ({ ...v, rust: JSON.parse(lines[lines.length - 2]).vers })); | ||
| } catch {} | ||
|
|
||
| // 4. VS Code Extension | ||
| try { | ||
| const res = await fetch( | ||
| 'https://marketplace.visualstudio.com/_apis/public/gallery/extensionquery', | ||
| { | ||
| method: 'POST', | ||
| headers: { | ||
| 'Content-Type': 'application/json', | ||
| Accept: 'application/json;api-version=3.0-preview.1', | ||
| }, | ||
| body: JSON.stringify({ | ||
| filters: [ | ||
| { | ||
| criteria: [ | ||
| { filterType: 8, value: 'Microsoft.VisualStudio.Code' }, | ||
| { filterType: 7, value: 'elijah-potter.harper' }, | ||
| ], | ||
| pageNumber: 1, | ||
| pageSize: 1, | ||
| sortBy: 0, | ||
| sortOrder: 0, | ||
| }, | ||
| ], | ||
| assetTypes: [], | ||
| flags: 194, | ||
| }), | ||
| }, | ||
| ); | ||
| const ver = (await res.json()).results[0].extensions[0].versions[0].version; | ||
| liveVersions.update((v) => ({ ...v, vscode: ver })); | ||
| } catch {} | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would love a brief doc-comment that explains what this function does. Also, is there a reason you don't simply return a memoized copy of the
liveVersionsobject? If you do, we can reduce the number of exports from this module.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do.
I'm not sure I really understand.