feat(weir): add SameExact rule to catch redundant "same exact"#3539
Open
jlaportebot wants to merge 4 commits into
Open
feat(weir): add SameExact rule to catch redundant "same exact"#3539jlaportebot wants to merge 4 commits into
jlaportebot wants to merge 4 commits into
Conversation
The phrase "same exact" is redundant since "same" already implies exactness. This rule flags "same exact" and suggests "same" alone. It correctly allows "exact same" which is a valid emphasis pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Weir rule that flags the redundant phrase
same exact, sincesamealready implies exactness. Suggestssamealone.Why this rule?
Changes
SameExact.weirrule with test cases and allows guardsdefault_config.json(alphabetical order)package.jsonTest coverage
All 69 weir tests pass, including
curated_default_config_lists_every_registered_rule.AI Disclosure
If Your PR Implements or Enhances a Linter
Checklist