feat: Expand conf, config, perf, and pref#3535
Open
hippietrail wants to merge 1 commit into
Open
Conversation
Also rename `ExpandDeref` to `ExpandDereference` for consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
N/A
Description
Expand "conf", "config", "perf", and "pref" to "configuration", "performance", and "preference".
Also covers the plurals "configs", and "prefs".
Also renames
ExpandDereftoExpandDereferencefor consistencyHow Has This Been Tested?
cargo testI expected
cargo test -- xpandto test all Weir and Rust expansion rules, but when it passed I still got failures withcargo test. So I'm missing something.@elijah-potter It would be great if you can run your fuzzer over this. I have a hunch it will have false positives following
.or with_on either side. If so that will mean we'll either want to add logic for Weir rules never to apply in those contexts, or to expand the scope ofstrategybeyondExactandMatchCase- perhaps addcontext? Or maybe this can already be handled by Weir syntax, in which case feel free to send a PR to this PR (-:AI Disclosure
If Your PR Implements or Enhances a Linter
Checklist