Skip to content

Capitalize off#3521

Open
hippietrail wants to merge 7 commits into
Automattic:masterfrom
hippietrail:capitalize-off
Open

Capitalize off#3521
hippietrail wants to merge 7 commits into
Automattic:masterfrom
hippietrail:capitalize-off

Conversation

@hippietrail
Copy link
Copy Markdown
Collaborator

@hippietrail hippietrail commented May 27, 2026

Issues

N/A

Description

I heard somebody say "capitalize off" instead of "capitalize on" on YouTube, verified that it's really a mistake and is reasonably common.

I'm using the new Weir directory with multiple files for the variants under a single name, rather than my good old phrase_set_corrections.

They cover all 4 verb inflections with both the -ize and -ise spellings, and with both "off" and "off of".

Lessons learned:

  1. In expr main the parentheses are optional if there's only one variation but compulsory if there are multiple:
  • expr main capitalise off of
  • expr main (capitalise off of)
  • expr main [capitalise off of, capitalise off]
  • expr main [(capitalise off of), (capitalise off)]
  1. When two variants share all the words but one has an extra word, the longer variant must be listed first:
  • expr main [(capitalise off), (capitalise off of)]
  • expr main [(capitalise off of), (capitalise off)]

How Has This Been Tested?

cargo test

AI Disclosure

  • I am a human and didn't use any AI.
  • I used LLM features of my editor, but not an agent.
  • I used an AI agent interactively.
  • I am an agent or I got an agent to do the work autonomously.

If Your PR Implements or Enhances a Linter

  • I made up the sentences in the unit tests.
  • The sentences in the unit tests were generated by an AI.
  • I'm using examples from the bug report / feature request.
  • I collected real-world sentences for the unit tests.

Checklist

  • I have performed a self-review of my own code
  • I have added tests to cover my changes
  • I have considered splitting this into smaller pull requests.

@hippietrail hippietrail added help wanted Extra attention is needed linting weir labels May 27, 2026
@hippietrail hippietrail marked this pull request as ready for review May 27, 2026 15:42
@hippietrail hippietrail removed the help wanted Extra attention is needed label May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants