feat(lint): add LifetimeLife rule to catch 'lifetime' where 'life' is meant#3518
Open
jlaportebot wants to merge 4 commits into
Open
feat(lint): add LifetimeLife rule to catch 'lifetime' where 'life' is meant#3518jlaportebot wants to merge 4 commits into
jlaportebot wants to merge 4 commits into
Conversation
… meant Detects common misuse of 'lifetime' in superlative expressions where 'life' is the correct word. Catches patterns like 'the best day of my lifetime' (→ 'life'), 'the biggest change in your lifetime' (→ 'life'), and similar constructions with superlative adjectives + preposition + possessive + lifetime. Does NOT flag valid uses: 'lifetime achievement', 'lifetime warranty', 'once in a lifetime', etc. 18 tests covering both detection and false-positive avoidance.
The test was failing because LifetimeLife was registered as a rule but missing from default_config.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new lint rule (
LifetimeLife) that detects common misuse oflifetimein superlative expressions wherelifeis the correct word.What it catches
Patterns where a superlative adjective is followed by a noun, a preposition (
of/in), a possessive determiner, andlifetime:Also handles bare forms without possessives: "the best game of lifetime" → "the best game of life"
What it does NOT flag (false positive avoidance)
lifetimeas attributive modifierlifetimemeaning durationImplementation
ExprLinterusingSentence-level matching withFirstMatchOfacross 9 pattern variants (3 prepositions × 3 possessive variants)then_fixed_phrasefor the preposition + possessive + lifetime patternAI Disclosure
If Your PR Implements or Enhances a Linter
Checklist