Keep mobile CSS when responsive bodies match - #96
Merged
Conversation
When desktop and mobile captures share a responsive body signature but their style blocks differ, the export returned the desktop document unchanged: mobile styles were dropped entirely and desktop styles were left unwrapped, so the page shipped with no mobile CSS. Keep the single shared body but merge CSS responsively: wrap desktop styles in media="(min-width:769px)" and append the mobile document style blocks as media="(max-width:768px)", without the .data-liberation-mobile-document scoping that only exists in two-body output. Identical bodies with identical styles keep the current single-document output, and differing bodies keep the existing two-document behavior. Known limitation (out of scope): mobile-only body attributes/classes are still lost when the shared desktop body is kept. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related work
Problem
When desktop and mobile captures had equivalent body markup but different style blocks, export kept only the desktop document. Mobile CSS was dropped entirely.
Changes
Ellen Bauer is preserved as the commit author. Claude Fable 5 is preserved as co-author.
Verification
npm run buildnpm test: 3,021 passed, 1 todonpm run test:packagenpm audit --omit=dev: 0 vulnerabilitiesHow AI was used
OpenAI GPT-5.6 Sol via OpenCode was used to compare the Studio and standalone implementations, port Ellen's source and regression tests, regenerate standalone distribution bundles, run verification, and prepare this PR.