small changes to text and UI#1215
Conversation
| </data> | ||
| <data name="StartWithWindowsFailed_Content" xml:space="preserve"> | ||
| <value>Auto start has been disabled in Windows Settings. To enable Auto Dark Mode to start with Windows again, please go to Windows Settings > Apps > Startup and enable it.</value> | ||
| <value>Auto start has been disabled in Windows Settings. To enable Auto Dark Mode to start with Windows, go to Windows Settings > Apps > Startup.</value> |
There was a problem hiding this comment.
Maybe we could turn this into a clickable link?
There was a problem hiding this comment.
Here is a dialog, and it is ready to jump. So we should not need other changes.
private async void OpenAutostartSettings()
{
await Windows.System.Launcher.LaunchUriAsync(new Uri("ms-settings:startupapps"));
}| </data> | ||
| <data name="AdaptiveTaskbarAccent" xml:space="preserve"> | ||
| <value>Use Taskbar Accent Color during</value> | ||
| <value>Use taskbar accent color during</value> |
There was a problem hiding this comment.
Taskbar is a name of an UI element. In english you write all names with an uppercase letter.
| <value>Select a theme</value> | ||
| </data> | ||
| <data name="PickTheme_Description" xml:space="preserve"> | ||
| <value>Select a different Windows theme for dark and light mode respectively. Allows full theme customization, but requires you to set up .theme files.</value> |
There was a problem hiding this comment.
Why should you remove this sentence explaining the hustle of this option?
There was a problem hiding this comment.
I thought the UX would be clear enough. There's a longer description on that page already.
Also: now it's one sentence that doesn't need a period at the end
There was a problem hiding this comment.
We can also make a long sentence without a period at the end :D
| <value>Let Windows manage my theme</value> | ||
| </data> | ||
| <data name="UpdateAtStart" xml:space="preserve"> | ||
| <value>Check when Auto Dark Mode starts</value> |
There was a problem hiding this comment.
Even Windows uses "Check" for updates and not "Searching". Gemini recommends me using "Check"
| </data> | ||
| <data name="StartWithWindowsFailed_Content" xml:space="preserve"> | ||
| <value>Auto start has been disabled in Windows Settings. To enable Auto Dark Mode to start with Windows again, please go to Windows Settings > Apps > Startup and enable it.</value> | ||
| <value>Auto start has been disabled in Windows Settings. To enable Auto Dark Mode to start with Windows, go to Windows Settings > Apps > Startup.</value> |
| <value>Windows colors</value> | ||
| </data> | ||
| <data name="Msg_AutomaticColorModeDescription" xml:space="preserve"> | ||
| <value>Automatic accent color is selected. The color will be determined by the current wallpaper</value> |
There was a problem hiding this comment.
Sorry, I just thought it was way too obvious, explaining what "automatic color" means?
There was a problem hiding this comment.
I think its good to have a message saying that automatic Color is activated. Without the message, its not obvious why the user doesnt see a color picker.
|
PRs like this improve tiny things, but some small things are actually intended. So this Pull Request needs many discussions (with me) which makes stuff like that hard to commit. |
|
@Armin2208 can you be specific? |
Armin2208
left a comment
There was a problem hiding this comment.
Merge is possible after resolving the comments
| <value>Path</value> | ||
| </data> | ||
| <data name="StartWithWindowsFailed_Content" xml:space="preserve"> | ||
| <value>Auto start has been disabled in Windows Settings. To enable Auto Dark Mode to start with Windows, go to Windows Settings > Apps > Startup.</value> |
There was a problem hiding this comment.
Again, why should someone remove a tutorial. You can rephrase it, but not removing the hint where to find it.
Yes I linked the Windows settings, but still.
| <value>Select a theme</value> | ||
| </data> | ||
| <data name="PickTheme_Description" xml:space="preserve"> | ||
| <value>Select a different Windows theme for dark and light mode respectively. Allows full theme customization, but requires you to set up .theme files.</value> |
There was a problem hiding this comment.
We can also make a long sentence without a period at the end :D
| <value>Windows colors</value> | ||
| </data> | ||
| <data name="Msg_AutomaticColorModeDescription" xml:space="preserve"> | ||
| <value>Automatic accent color is selected. The color will be determined by the current wallpaper</value> |
There was a problem hiding this comment.
I think its good to have a message saying that automatic Color is activated. Without the message, its not obvious why the user doesnt see a color picker.
| <value>Select a theme</value> | ||
| </data> | ||
| <data name="PickTheme_Description" xml:space="preserve"> | ||
| <value>Select a different Windows theme for dark and light mode respectively. Allows full theme customization, but requires you to set up .theme files.</value> |
| </data> | ||
| <data name="StartWithWindowsFailed_Content" xml:space="preserve"> | ||
| <value>Auto start has been disabled in Windows Settings. To enable Auto Dark Mode to start with Windows again, please go to Windows Settings > Apps > Startup and enable it.</value> | ||
| <value>Auto start is disabled in Windows Settings.</value> |
| <value>Windows colors</value> | ||
| </data> | ||
| <data name="Msg_AutomaticColorModeDescription" xml:space="preserve"> | ||
| <value>Automatic accent color is selected. The color will be determined by the current wallpaper</value> |
| <!-- Accent Color --> | ||
| <StackPanel Spacing="{StaticResource SettingsCardSpacing}"> | ||
|
|
||
| <!-- Automatic color mode info --> |

Simplified a few strings and even deleted a few.
Reverted UX to
SettingsCard IsEnabled="{x:Bind ViewModel.AutoThemeSwitchingEnabled