fix(llm): default Gemini supportsParallelTools to false - #212
Open
yablokolabs wants to merge 1 commit into
Open
Conversation
…alse The previous fix (PR AtomicBot-ai#207) threaded provider capabilities through to the parallel_tool_calls wire, but every built-in provider kind set supportsParallelTools from supportsTools — so Gemini (which supports tools) always got true, and the capability term was inert for the exact use case issue AtomicBot-ai#104 describes. This adds an explicit supportsParallelTools?: boolean field to LlmProviderConfigEntry and the user config schema. Every provider kind reads it with fallback to supportsTools, but Gemini defaults to false overriding that fallback. Users can explicitly set supportsParallelTools: true on a Gemini entry to opt in. 7 new tests (3 config round-trip, 2 registry Gemini default/override, 2 rejection).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to PR #207 (fixes #104). The review on #207 flagged that the provider-capability half of the fix is currently inert for Gemini — every built-in provider kind sets
supportsParallelToolsfromsupportsTools, and since Gemini supports tools, the capability is alwaystrue. The only provider that declaredfalsewassubscription-cli.This adds an explicit
supportsParallelTools?: booleanfield to the provider config entry and the user config schema. Every provider kind reads it with fallback tosupportsTools, but Gemini defaults tofalse— overriding the fallback. Users can explicitly setsupportsParallelTools: trueon a Gemini entry to opt in if their deployment supports it.Changes
src/config/llm-config.ts— newsupportsParallelTools?: booleanfield onUserLlmProviderEntry+ parsersrc/config/config-schema.ts— schema acceptance for the new fieldsrc/llm/provider/registry/provider-types.ts— new field onLlmProviderConfigEntrysrc/llm/provider/registry/register-built-in-providers.ts— all kinds useentry.supportsParallelTools ?? entry.supportsTools ?? true; Gemini usesentry.supportsParallelTools ?? falseTest coverage
7 new tests:
parseLlmProviderEntry(explicittrueandfalse), absent field staysundefined, non-boolean rejectedsupportsParallelToolstofalse, explicittrueoverride respectedVerification
npm run lintcleansrc/llm/,src/agent/,src/config/