Repository navigation
fix(cli): berth test boots production images again - #301
Merged
Merged
Conversation
Production images set BERTH_REQUIRE_APP_CGROUPS=1 since per-app cgroups landed (#222), and berth test's single-app path is a plain docker run that delegates no cgroup subtree. The entrypoint refused every boot, so berth test failed on every new single app, and the release dry run did too. Its refusal event was then read as the check's result, which had no ok field, so the failure printed no reason. Run the check with BERTH_REQUIRE_APP_CGROUPS=0, accept only a JSON line with a boolean ok as the result, and print the result's error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
berth testhas been failing on every new single app since per-app cgroups landed in #222, and that's also why the 0.3.0 release dry run fails.Production images set
BERTH_REQUIRE_APP_CGROUPS=1.berth test's single-app path is a plaindocker runthat doesn't delegate a cgroup subtree, so the entrypoint refuses to boot. Its refusal is a JSON event line, whichberth testthen took as the check's result. That result has nook, so it reported "contracts failed:" with nothing after it.Three changes:
BERTH_REQUIRE_APP_CGROUPS=0. A test run checks exports, not per-app limits, and the entrypoint still warns.okas the result, so an event line can't stand in for it.error, which was never shown.Checked on Linux (Docker 29, Node 22.23) with the release workflow's own steps: scaffold hello-world against the packed SDK, build,
berth test. Before:exportCheckis thecgroup_delegation_refusedevent. After:✓ manifest + export contracts (1 exports checked).