Repository navigation
fix: require Node 22.19, the floor undici 8 already needs - #299
Merged
Merged
Conversation
@berthos/sdk and @berthos/tls depend on undici 8, whose every release declares node >=22.19.0 and fails to load on older 22.x. Our engines said >=22, so npm installed cleanly on 22.0 to 22.18 and the SDK then crashed on import. Raise every package's floor and the docs to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SDK and tls depend on undici 8, and every undici 8 release needs Node 22.19 or later. On anything older it fails to load, so on Node 22.14 importing the SDK crashes. Our
enginessaid>=22, so npm installed without a word on 22.0 to 22.18 and then it broke at runtime. v0.2.4 has the same gap.This raises
enginesto>=22.19in every package and updates the docs that said Node 22+. Nothing else changes; CI already runs on the latest 22.