-
Notifications
You must be signed in to change notification settings - Fork 47
[feat] Make ds_max_workers configurable in YuanrongStorageClient #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -205,6 +205,11 @@ def __init__(self, config: dict): | |
| if port is None or not isinstance(port, int): | ||
| raise ValueError("Missing or invalid 'worker_port' in config") | ||
|
|
||
| ds_max_workers = config.get("ds_max_workers", self.DS_MAX_WORKERS) | ||
| if not isinstance(ds_max_workers, int) or ds_max_workers < 1: | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When a YAML/config override supplies AGENTS.md reference: AGENTS.md:L17-L18 Useful? React with 👍 / 👎. |
||
| raise ValueError(f"Invalid 'ds_max_workers' in config: {ds_max_workers}. Expecting a positive integer") | ||
| self.DS_MAX_WORKERS = ds_max_workers | ||
|
|
||
| logger.info(f"Auto-detecting reachable host for Yuanrong port {port}...") | ||
| host = find_reachable_host(port) | ||
| if host is None: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also reflect in performance test config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done