Skip to content

feat: add shareLinks prop to documentation page - #674

Merged
ItsANameToo merged 4 commits into
mainfrom
feat/docs-share-links-prop
Aug 18, 2026
Merged

ItsANameToo merged 4 commits into
mainfrom
feat/docs-share-links-prop

Conversation

@alfonsobries

@alfonsobries alfonsobries commented Jul 29, 2026 •

Copy link
Copy Markdown
Member

Depends on #672 (stacked on it, same as #671).

Dependency of https://github.com/ArkEcosystem/ark.dev/pull/382

Adds a shareLinks prop to pages/documentation.blade.php, same pattern as the existing editOption prop, so consumers can opt out of the share-links block instead of forking the whole view. Defaults to true, no behavior change for existing consumers.

https://app.clickup.com/t/2570579/86e2h1p3t

@alfonsobries
alfonsobries changed the base branch from main to chore/pin-and-normalize-rustywind July 29, 2026 16:21
@alfonsobries
alfonsobries force-pushed the chore/pin-and-normalize-rustywind branch 2 times, most recently from a249248 to 7203774 Compare August 10, 2026 16:10
@alfonsobries
alfonsobries force-pushed the feat/docs-share-links-prop branch from ebc6788 to 77ac676 Compare August 10, 2026 16:12
rustywind is unmaintained and only reorders classes, while the wider
Tailwind + Prettier ecosystem has moved to prettier-plugin-tailwindcss.
Prettier has no native Blade parser though (confirmed upstream in
tailwindlabs/prettier-plugin-tailwindcss#41), so @shufo/prettier-plugin-blade
is added to give Prettier real Blade support, with sortTailwindcssClasses
enabled to replace rustywind's job.

Since this is a real Prettier plugin, it reformats each blade file as a
whole (indentation, attribute wrapping, PHP inside directives), not just
the class attribute like rustywind did. Embedded PHP ends up styled
differently from the rest of the codebase's php-cs-fixer rules (e.g.
spaced concatenation, no space after `!`), since php-cs-fixer already
excludes *.blade.php and blade-formatter (which this plugin wraps)
doesn't offer a way to opt out of PHP formatting.
Whitespace-sensitive assertions (literal HTML strings, snapshot fixtures)
needed updating to match the new formatting; no behavioral changes.
@alfonsobries
alfonsobries force-pushed the chore/pin-and-normalize-rustywind branch from 7203774 to 00f35f4 Compare August 10, 2026 17:31
@alfonsobries
alfonsobries force-pushed the feat/docs-share-links-prop branch from 77ac676 to 69c37a0 Compare August 10, 2026 17:33
Base automatically changed from chore/pin-and-normalize-rustywind to main August 18, 2026 10:15
@ItsANameToo
ItsANameToo marked this pull request as ready for review August 18, 2026 10:21
@ItsANameToo
ItsANameToo merged commit b5e1d74 into main Aug 18, 2026
7 checks passed
@ItsANameToo
ItsANameToo deleted the feat/docs-share-links-prop branch August 18, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants