Skip to content

[esphome] Modernise board spec and remove legacy platformio/BLE config#61

Merged
TrevorSchirmer merged 1 commit into
betafrom
esphome-modernisation
Feb 27, 2026
Merged

[esphome] Modernise board spec and remove legacy platformio/BLE config#61
TrevorSchirmer merged 1 commit into
betafrom
esphome-modernisation

Conversation

@bharvey88
Copy link
Copy Markdown
Contributor

Version: 25.8.12.1

What does this implement/fix?

Ports the non-breaking modernisation changes from MTR-1 PR #74 to the MSR-2 (web_server: version: 3 was already present):

Core.yaml

  • esp32: replaced board: esp32-c3-devkitm-1 with variant: esp32c3 + flash_size: 4MB (new ESPHome board spec)

MSR-2.yaml, MSR-2_BLE.yaml, MSR-2_Factory.yaml

  • Removed platformio_options: board_build.flash_mode: dio (no longer needed with the new variant spec)

MSR-2_Factory.yaml

  • Removed legacy on_connect/on_disconnect BLE enable/disable wifi hooks

Note: min_version was intentionally not changed. The servicesactions rename is handled separately in its own breaking-change PR.

Types of changes

  • Bugfix (fixed change that fixes an issue)
  • New feature (thanks!)
  • Breaking change (repair/feature that breaks existing functionality)
  • Dependency Update - Does not publish
  • Other - Does not publish
  • Website of github readme file update - Does not publish
  • Github workflows - Does not publish

Checklist / Checklijst:

  • The code change has been tested and works locally
  • The code change has not yet been tested

If user-visible functionality or configuration variables are added/modified:

  • Added/updated documentation for the web page

- esp32: board -> variant: esp32c3 + flash_size: 4MB
- Remove platformio_options board_build.flash_mode from all device YAMLs
- MSR-2_Factory: remove legacy BLE on_connect/on_disconnect wifi hooks
@github-actions github-actions Bot added the new-feature New feature label Feb 24, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Feb 24, 2026

Warning

Rate limit exceeded

@bharvey88 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 13 minutes and 14 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between be70ff5 and d7d33ac.

📒 Files selected for processing (4)
  • Integrations/ESPHome/Core.yaml
  • Integrations/ESPHome/MSR-2.yaml
  • Integrations/ESPHome/MSR-2_BLE.yaml
  • Integrations/ESPHome/MSR-2_Factory.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch esphome-modernisation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@TrevorSchirmer TrevorSchirmer merged commit 2466690 into beta Feb 27, 2026
12 checks passed
@TrevorSchirmer TrevorSchirmer deleted the esphome-modernisation branch February 27, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature New feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants