test(puppeteer): cover SharedWorker cursor restoration - #92
Closed
marcus-pousette wants to merge 1 commit into
Closed
test(puppeteer): cover SharedWorker cursor restoration#92marcus-pousette wants to merge 1 commit into
marcus-pousette wants to merge 1 commit into
Conversation
marcus-pousette
force-pushed
the
test/shared-worker-cursor-restoration
branch
from
July 14, 2026 10:59
c05cf30 to
020d029
Compare
marcus-pousette
force-pushed
the
test/shared-worker-cursor-restoration
branch
from
July 14, 2026 21:01
020d029 to
c4a75e8
Compare
marcus-pousette
changed the base branch from
fix/wa-sqlite-shared-worker-persistence
to
main
July 14, 2026 21:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node_modulescache cannot restore dependencies without a browser binaryWhy
em should cover the user-visible “open, persist, reload, restore cursor” path. TreeCRDT owns the lower-level failed-open and stale-worker regressions, now covered by cybersemics/treecrdt#208. The exact over-64-byte pathname regression remains covered by cybersemics/treecrdt#221.
The legacy Browserless image hangs after persisted SharedWorker reloads with the current Puppeteer client. Puppeteer's pinned Chrome completes the same reload normally. Running only the two restoration tests there avoids an unrelated visual-snapshot migration.
Verification
mainafter Bump @treecrdt/wa-sqlite to 0.3.2 #91 and Sync upstream main (2026-07-14) #93 mergedgit diff --checkThe workflow still runs the complete Browserless Puppeteer suite after the focused pinned-Chrome run. Puppeteer CI run