Skip to content

test(puppeteer): cover SharedWorker cursor restoration - #92

Closed
marcus-pousette wants to merge 1 commit into
mainfrom
test/shared-worker-cursor-restoration
Closed

test(puppeteer): cover SharedWorker cursor restoration#92
marcus-pousette wants to merge 1 commit into
mainfrom
test/shared-worker-cursor-restoration

Conversation

@marcus-pousette

@marcus-pousette marcus-pousette commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • reuse the two existing cursor-restoration reload tests for SharedWorker + OPFS integration coverage
  • let the persistent TreeCRDT fixture select a runtime without changing the default direct + OPFS suite
  • rerun only that existing test group in Puppeteer's pinned Chrome
  • keep the established Browserless visual suite unchanged
  • install the pinned browser explicitly so the upstream node_modules cache cannot restore dependencies without a browser binary

Why

em should cover the user-visible “open, persist, reload, restore cursor” path. TreeCRDT owns the lower-level failed-open and stale-worker regressions, now covered by cybersemics/treecrdt#208. The exact over-64-byte pathname regression remains covered by cybersemics/treecrdt#221.

The legacy Browserless image hangs after persisted SharedWorker reloads with the current Puppeteer client. Puppeteer's pinned Chrome completes the same reload normally. Running only the two restoration tests there avoids an unrelated visual-snapshot migration.

Verification

The workflow still runs the complete Browserless Puppeteer suite after the focused pinned-Chrome run. Puppeteer CI run

@marcus-pousette marcus-pousette added the skip-tdd-puppeteer Skip Puppeteer TDD validation for test maintenance changes label Jul 14, 2026
@marcus-pousette
marcus-pousette force-pushed the test/shared-worker-cursor-restoration branch from c05cf30 to 020d029 Compare July 14, 2026 10:59
@marcus-pousette
marcus-pousette force-pushed the test/shared-worker-cursor-restoration branch from 020d029 to c4a75e8 Compare July 14, 2026 21:01
@marcus-pousette
marcus-pousette changed the base branch from fix/wa-sqlite-shared-worker-persistence to main July 14, 2026 21:01
@Antonov548 Antonov548 closed this Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-tdd-puppeteer Skip Puppeteer TDD validation for test maintenance changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants