Skip to content

Inline settings bootstrap helper #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Antonov548 merged 1 commit into from
Jun 4, 2026
Merged

Inline settings bootstrap helper #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions src/actions/ensureSettingsThought.ts
View file
Open in desktop

This file was deleted.

16 changes: 13 additions & 3 deletions src/actions/settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
import _ from 'lodash'
import State from '../@types/State'
import Thunk from '../@types/Thunk'
import { EM_TOKEN, SETTINGS_VALUE } from '../constants'
import { EM_TOKEN, SETTINGS_TOKEN, SETTINGS_VALUE } from '../constants'
import findDescendant from '../selectors/findDescendant'
import getPrevRank from '../selectors/getPrevRank'
import { registerActionMetadata } from '../util/actionMetadata.registry'
import ensureSettingsThought from './ensureSettingsThought'
import createThought from './createThought'
import toggleAttribute from './toggleAttribute'

/** Sets a setting thought. */
Expand All @@ -13,7 +14,16 @@ const settings = (state: State, { key, value }: { key: string; value: string })
const exists = !!findDescendant(state, EM_TOKEN, emContext)
if (exists) return state

return toggleAttribute(ensureSettingsThought(state), { path: [EM_TOKEN], values: emContext })
const stateWithSettings = findDescendant(state, EM_TOKEN, SETTINGS_VALUE)
? state
: createThought(state, {
id: SETTINGS_TOKEN,
path: [EM_TOKEN],
value: SETTINGS_VALUE,
rank: getPrevRank(state, EM_TOKEN),
})

return toggleAttribute(stateWithSettings, { path: [EM_TOKEN], values: emContext })
}

/** Action-creator for settings. */
Expand Down