Feature/core refactor

.github/workflows/CI.yml

@@ -2,7 +2,7 @@ name: CI
 
 on:
   push:
-    branches: [master]
+    branches: [master, feature/**, fix/**]
     paths-ignore:
       - "**.md"
 
@@ -14,8 +14,11 @@ on:
 env:
   PACKAGE_NAME: VipModular
   STORE_README: 0
-  GENERATE_PLUGINS_INI: 1
+  PLUGINS_INI_GENERATE: 1
   PLUGINS_INI_POSTFIX: vipm
+  DEPS_LIST: |
+    AmxxModularEcosystem/ParamsController@1.4.0
+    AmxxModularEcosystem/CommandAliases@1.0.1
 
 jobs:
   build:
@@ -52,6 +55,7 @@ jobs:
       - name: Setup latest ReAPI includes
         env:
           REPO: "rehlds/ReAPI"
+          OUTPUT_VAR_NAME: REAPI_INCLUDE_PATH
         run: |
           mkdir -p dep/reapi
           cd dep/reapi
@@ -64,7 +68,12 @@ jobs:
 
           7z x *.zip
 
-          echo "REAPI_INCLUDE_PATH=$(pwd)/addons/amxmodx/scripting/include" >> $GITHUB_ENV
+          echo "${OUTPUT_VAR_NAME}=$(pwd)/addons/amxmodx/scripting/include" >> $GITHUB_ENV
+
+      - uses: AmxxModularEcosystem/install-amxmodx-deps@v1
+        with:
+          deps_list: ${{ env.DEPS_LIST }}
+          output_var_name: DEPS_COMPILER_ARGS
 
       - name: Setup AMXXPawn Compiler
         uses: wopox1337/setup-amxxpawn@v1.1.0
@@ -75,8 +84,9 @@ jobs:
         working-directory: amxmodx/scripting/
         env:
           REAPI_INCLUDE: ${{ env.REAPI_INCLUDE_PATH }}
-          GENERATE_PLUGINS_INI: ${{ env.GENERATE_PLUGINS_INI }}
+          PLUGINS_INI_GENERATE: ${{ env.PLUGINS_INI_GENERATE }}
           PLUGINS_INI_POSTFIX: ${{ env.PLUGINS_INI_POSTFIX }}
+          DEPS_COMPILER_ARGS: ${{ env.DEPS_COMPILER_ARGS }}
         run: |
           compile() {
             sourcefile=$1
@@ -85,13 +95,14 @@ jobs:
 
             mkdir -p $(dirname $output_path)
 
-            echo -n "Compiling $sourcefile ... "
+            echo "Compiling $sourcefile... "
             amxxpc $sourcefile -o"$output_path" \
               -i"include" \
               -i"$REAPI_INCLUDE" \
-              -i"$PARAMS_CONRTOLLER_INCLUDE"
+              $DEPS_COMPILER_ARGS \
+              GITHUB_ACTIONS_USED=1
 
-            if [ ! -z "${GENERATE_PLUGINS_INI}" ]; then
+            if [ ! -z "${PLUGINS_INI_GENERATE}" ]; then
               plugin_ini_path="../configs/plugins-${PLUGINS_INI_POSTFIX}.ini"
               touch $plugin_ini_path
               echo $amxxfile >> $plugin_ini_path

.gitignore

@@ -2,3 +2,4 @@
 *.zip
 .build
 plugins-*.ini
+.claude

CLAUDE.md

@@ -0,0 +1,186 @@
+# VipModular — Project Context
+
+Modular VIP/privilege system for **Counter-Strike 1.6** built on **AMX Mod X** (AMXX), written in **Pawn**.  
+Version: `5.0.0-rc4f1` | Author: ArKaNeMaN
+
+> For deeper detail on each subsystem, see `docs/claude/`.
+
+---
+
+## What it does
+
+Lets server admins define privilege tiers (VIPs) in JSON configs. Each privilege specifies:
+- **Conditions** (`Access`) — which players qualify (Limits system)
+- **Features** (`Modules`) — what those players get (Modules system)
+
+Modules and limits are fully extensible: third-party plugins register new types at runtime.
+
+---
+
+## Plugin files
+
+| File | Role |
+|------|------|
+| `VipModular.sma` | Core — init, config loading, player update lifecycle |
+| `ItemsController.sma` | Standalone item-effects framework (give weapon/health/etc.) |
+| `VipM-Misc.sma` | Reload helper — triggers `VipM_UserUpdate` on spawn/round events |
+| `VipM-ModulesLimiter.sma` | Enables/disables modules per-map via `Modules.json` |
+| `VipM-M-WeaponMenu.sma` | Module: weapon selection menu |
+| `VipM-M-SpawnItems.sma` | Module: give items on spawn |
+| `VipM-M-SpawnHealth.sma` | Module: set health/armor on spawn |
+| `VipM-M-Vampire.sma` | Module: heal on kill |
+| `VipM-M-VipInTab.sma` | Module: VIP label in scoreboard |
+
+---
+
+## Source layout
+
+```
+amxmodx/scripting/
+├── include/VipModular.inc        — public API header (include this in plugins)
+├── include/VipM/Modules.inc      — module system API
+├── include/VipM/Limits.inc       — limits system API
+├── include/ItemsController.inc   — items system API
+├── VipM/
+│   ├── Core/
+│   │   ├── VipsManager.inc       — loads Vips.json, manages g_tUserModules[]
+│   │   ├── Objects/Modules/Type.inc  — module type registry (ArrayMap)
+│   │   ├── Objects/Modules/Unit.inc  — module instance (params per VIP entry)
+│   │   ├── Objects/Limits/Type.inc   — limit type registry
+│   │   ├── Objects/Limits/Unit.inc   — limit instance
+│   │   ├── Objects/VipUnit.inc        — deserializes one privilege from JSON
+│   │   └── API/{Main,Modules,Limits}.inc — native implementations
+│   ├── DefaultObjects/
+│   │   ├── Limit/*.inc           — 24 built-in limit types
+│   │   └── Registrar.inc         — registers all defaults
+│   ├── Forwards.inc              — thin macro wrapper over CreateMultiForward
+│   ├── ArrayMap.inc              — string-keyed array map (used for type registries)
+│   └── WeaponMenu/               — WeaponMenu module implementation
+└── ItemsController/
+    ├── Objects/Items/{Type,Instance}.inc
+    ├── API/{ItemType,Item,Compat}.inc
+    └── DefaultObjects/ItemType/  — 18 built-in item types
+```
+
+---
+
+## Core data flow
+
+```
+plugin_precache
+  Forwards_RegAndCall("VipM_Modules_OnInited")  ← modules register here
+  Forwards_RegAndCall("VipM_Limits_OnInited")   ← limits register here
+  IC_ItemType_OnInited()                         ← item types register here
+  VipsManager_LoadFromFile("Vips.json")
+  VipsManager_LoadFromFolder("Vips/")
+  ModuleType_ActivateUsed()                      ← fires Module_OnActivated
+  Forwards_RegAndCall("VipM_OnLoaded")
+
+client_putinserver → RequestFrame → VipsManager_UserReload(playerIndex)
+  for each VipUnit: check Access limits → grant matching Modules
+  result stored in g_tUserModules[playerIndex]: Trie<moduleName → Trie<params>>
+  fires VipM_OnUserUpdated(playerIndex)
+
+client_disconnected → VipsManager_UserReset(playerIndex)  ← frees all Tries
+```
+
+---
+
+## Key patterns
+
+- **Type registries** use `ArrayMap` (string key → index cast to enum type, e.g. `T_ModuleType`, `T_LimitType`)
+- **Params** stored in AMXX `Trie` (string key → value); parsed from JSON via ParamsController
+- **Forwards** wrapped in `Forwards_Reg` / `Forwards_Call` macros (`VipM/Forwards.inc`)
+- **Object handles** are array indices cast to enum type — `Invalid_*` sentinel = `-1`
+- **Static limits** store a bitmask instead of calling a forward (faster, no params)
+
+---
+
+## External dependencies
+
+| Library | Min version | Purpose |
+|---------|-------------|---------|
+| ParamsController | 1.3.2 | JSON parsing, param reading, path utils (`PCPath_*`, `PCJson_*`, `PCGet_*`) |
+| CommandAliases | 1.0.1 | Server command aliasing |
+| ReAPI | 5.24.0.300 | Game hooks: `RG_CBasePlayer_Spawn`, `RG_CSGameRules_RestartRound`, etc. |
+
+---
+
+## Config files
+
+All under `amxmodx/configs/plugins/VipModular/`:
+
+| File | Purpose |
+|------|---------|
+| `Vips.json` | Privilege definitions (or `Vips/` folder for multiple files) |
+| `Modules.json` | Module enable/disable rules (read by `VipM-ModulesLimiter`) |
+| `Items/*.json` | Reusable item definitions |
+
+`"File:WeaponMenu/Premium"` in JSON → resolves to `configs/plugins/VipModular/WeaponMenu/Premium.json`
+
+---
+
+## Local-only docs
+
+Some context is intentionally kept out of the repository (e.g. local tool paths).  
+Check `.claude/` memory for a `local-env.md` file — if it exists, read it before working with the build system or dependency headers.
+
+---
+
+## Sub-docs
+
+- [`docs/claude/module-system.md`](docs/claude/module-system.md) — registering & using modules
+- [`docs/claude/limits-system.md`](docs/claude/limits-system.md) — registering & using limits
+- [`docs/claude/items-system.md`](docs/claude/items-system.md) — ItemsController API
+- [`docs/claude/config-format.md`](docs/claude/config-format.md) — Vips.json format reference
+
+---
+
+## Working rules for Claude
+
+### Code style
+
+Match the existing style exactly. Key conventions:
+
+**Naming — identifiers**
+
+| Kind | Convention | Example |
+|------|-----------|---------|
+| Local variables | camelCase | `playerIndex`, `menuIndex`, `params` |
+| Global variables | PascalCase (capital first letter) | `UserAutoOpen`, `UserLeftItems`, `Vips` |
+| Public functions / API | `Namespace_PascalCase` | `VipsManager_Init`, `ModuleType_Find` |
+| Static (private) functions | `Namespace_PascalCase` + `static` keyword | `static LimitType_Get(...)` |
+| Internal helpers | `_PascalCase` | `_Cmd_Menu` |
+| Native/forward callbacks | `@FullNativeName` | `@RG_CBasePlayer_Spawn`, `@Module_OnActivated` |
+| Enum handle types | `T_Name` | `T_ModuleType`, `T_VipUnit` |
+| Enum struct layouts | `S_Name` | `S_ModuleType`, `S_WeaponMenu` |
+| Enum (actual enumerations) | `E_Name` | `E_ModuleEvent`, `E_LimitEvent` |
+| Enum fields | `StructName_FieldName` | `ModuleType_Name`, `VipUnit_Access` |
+| Constants / macros | `SCREAMING_SNAKE_CASE` | `MODULE_NAME`, `TASK_OFFSET_AUTO_OPEN` |
+
+**No Hungarian notation anywhere.** Don't add `i`, `s`, `f`, `b`, `g`, `g_` prefixes to variables — not on locals, not on globals. The existing codebase has legacy `g_aVips`, `gUserAutoOpen`, `iRet`, `sName` etc. — don't copy that pattern into new code.
+
+**Formatting**
+- 4-space indentation
+- Braces on same line for control flow: `if (...) {`
+- Single blank line between logical blocks; two blank lines between top-level function definitions
+- Long argument lists: one argument per line, aligned to opening paren
+- Conditions spanning multiple lines: each sub-condition on its own line, operator at start
+
+**Other**
+- Use `PCGet_*` / `PCSingle_*` helpers from ParamsController for reading params from Trie/JSON — don't read Tries directly where a helper exists
+- Prefer `Invalid_*` sentinel checks over magic `-1` literals
+- Don't add error handling for cases the framework already guards against
+
+---
+
+### Documentation maintenance
+
+**After every code change, update the relevant `docs/claude/*.md` file** to reflect what changed:
+- New module → update `docs/claude/module-system.md`
+- New/changed limit type → update `docs/claude/limits-system.md`
+- New/changed item type → update `docs/claude/items-system.md`
+- Config format change → update `docs/claude/config-format.md`
+- Structural change affecting multiple systems → update `CLAUDE.md` and the affected sub-docs
+
+If a change doesn't fit any existing sub-doc, create a new one in `docs/claude/` and add it to the sub-docs list above.

README.md

@@ -1,7 +1,13 @@
-# Modular Vip System
+# Vip Modular
 
 Модульная система привилегий.
 
+## Требования
+
+- [ParamsController](https://github.com/AmxxModularEcosystem/ParamsController) версии [1.4.0](https://github.com/AmxxModularEcosystem/ParamsController/releases/tag/1.4.0) или [выше](https://github.com/AmxxModularEcosystem/ParamsController/releases/latest).
+- [CommandAliases](https://github.com/AmxxModularEcosystem/CommandAliases) версии [1.0.1](https://github.com/AmxxModularEcosystem/CommandAliases/releases/tag/1.0.1-fix1) или [выше](https://github.com/AmxxModularEcosystem/CommandAliases/releases/latest).
+- [ReAPI](https://github.com/rehlds/ReAPI) версии [5.24.0.300](https://github.com/rehlds/ReAPI/releases/tag/5.24.0.300) или [выше](https://github.com/rehlds/ReAPI/releases/latest).
+
 ## Инструкции по настройке
 
 - [Основные настройки](readme/configs.md)
@@ -15,18 +21,12 @@
 | :-------------------------------- | :---------------------------------------------------------- |
 | `vipm_update_users`               | Обновляет привилегии у всех игроков                         |
 | `vipm_info`                       | Выводит информацию о системе привилегий                     |
-|                                   |                                                             |
 | `vipm_modules`                    | Выводит таблицу модулей и их статусов                       |
-| `vipm_module_params <ModuleName>` | Выводит таблицу параметров указанного модуля                |
-|                                   |                                                             |
 | `vipm_limits`                     | Выводит таблицу типов проверок и некоторую информацию о них |
-| `vipm_limit_params <LimitType>`   | Выводит таблицу параметров указанного типа проверки         |
-|                                   |                                                             |
-| `vipm_ic_types`                   | Выводит таблицу типов предметов                             |
+| `ic_item_types`                   | Выводит таблицу типов предметов                             |
 
 ## Идеи
 
 - _\[Configs\]_ Добавить глобальные настройки типа ключ-значение, на которые можно ссылаться из основных конфигов как на файлы, только с префиксом Var:
 - _\[Modules\]_ Переработать обьедининение параметров модулей
-- _\[ReadMe\]_ Нарисовать схему взаимодействия компонентов системы
-- _\[IC\]_ Придумать как норм отвязать IC от ядра и, возможно, вынести его в отдельный репо
+- _\[IC\]_ Придумать как норм отвязать IC от ядра и, возможно, вынести его в отдельный репо (WIP)

amxmodx/configs/plugins/CommandAliases/VipM-M-WeaponMenu.json

@@ -0,0 +1,34 @@
+[
+    {
+        "Command": "vipm_m_weaponmenu_menu",
+        "Alias": [
+            "vm",
+            "say /vm",
+            "say_team /vm",
+            "vipmenu",
+            "say /vipmenu",
+            "say_team /vipmenu"
+        ]
+    },
+    {
+        "Command": "vipm_m_weaponmenu_menu_silent",
+        "Alias": [
+            "vm_silent",
+            "vipmenu_silent"
+        ]
+    },
+    {
+        "Command": "vipm_m_weaponmenu_autoopen_toggle",
+        "Alias": [
+            "vm_autoopen",
+            "say /vm_autoopen",
+            "say_team /vm_autoopen",
+            "vm_ao",
+            "say /vm_ao",
+            "say_team /vm_ao",
+            "vipmenu_autoopen",
+            "say /vipmenu_autoopen",
+            "say_team /vipmenu_autoopen"
+        ]
+    }
+]