fix: send a fixed fee limit on Transactions.send [AMB-2979] - #37
Merged
bufo24 merged 1 commit intoAug 17, 2026
Merged
Conversation
bufo24
force-pushed
the
jesseva/amb-2979-update-fee-limit-in-sdk-for-sending
branch
2 times, most recently
from
August 17, 2026 13:06
d0c7e7c to
aa9df6d
Compare
bufo24
marked this pull request as ready for review
August 17, 2026 13:06
wthrajat
approved these changes
Aug 17, 2026
bufo24
changed the title
fee_limit_sat was dropped entirely from node payment requests in #33, which risks the node applying its own restrictive default. Send a fixed 4294967296 sats (effectively unlimited) on every send instead of exposing fee-limit configuration to callers again.
bufo24
force-pushed
the
jesseva/amb-2979-update-fee-limit-in-sdk-for-sending
branch
from
August 17, 2026 13:10
aa9df6d to
565aeb0
Compare
Merged
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fee_limit_satwas dropped entirely from LND/litd send requests in fix!: remove fee limit from Transactions.send #33. Reintroduces it as a fixed4294967296sats (~42.9 BTC — effectively unlimited) sent on everyTransactions.send()call, rather than restoring it as a caller-configurable param.SendParams).Test plan
pnpm buildpnpm typecheck(+typecheck:examplesfor the.ctsexample)pnpm test— added an assertion intransactions.send.test.tsthat the outgoing node request body carriesfee_limit_sat: '4294967296'pnpm format:check