fix: translate resource-call errors into ApiError - #18
Merged
Conversation
Resource calls (environments/wallets/transactions) use the generated SDK client directly rather than AmbossClient.gqlRequest, so raw graphql-request ClientErrors escaped untranslated — contradicting the documented contract that these calls throw ApiError/NetworkError. Pass a translating SdkFunctionWrapper to every getSdk call so errors are converted at the single generated-client boundary.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The payments README documents that resource calls throw the SDK's typed errors:
But
Environments,Wallets, andTransactionscall the generated client viagetSdk(graphqlClient)directly, bypassingAmbossClient.gqlRequest(which is wheretranslateErrorruns). So these calls actually throw rawgraphql-requestClientErrors —err instanceof ApiErroris alwaysfalse, and the documented error contract is broken.Fix
Added
translateSdkErrors, anSdkFunctionWrapperthat runsAmbossClient.translateErroron any thrown error, and passed it to everygetSdk(...)call. Translation happens once, at the generated-client boundary, so all current and future resource methods are covered.Tests
Added
sdkErrors.test.ts: a resource call whose fetch returns a GraphQL error now rejects withApiError(message preserved), not a rawClientError.Verified: typecheck ✓, build ✓, format ✓, 28/28 payments tests ✓.
Note
Touches
packages/payments, so this cuts the next release —@ambosstech/payments@0.1.1(its first published bump) — which is what exercises the corrected publish pipeline.