ci: single-source the pnpm version via packageManager - #17
Merged
Conversation
pnpm/action-setup errored with ERR_PNPM_BAD_PM_VERSION because the workflow pinned version 10.19.0 while package.json packageManager still said pnpm@10.5.2. Bump packageManager to 10.19.0 (OIDC-capable) and drop the redundant version: pins from both workflows so action-setup derives the version from packageManager — one source of truth, no conflict.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The publish job failed on
pnpm/action-setup@v4:PR #12 bumped the workflow's
version:to 10.19.0 for OIDC but leftpackage.json'spackageManageratpnpm@10.5.2.action-setupv4 treats the mismatch as a hard error.Fix
One source of truth:
package.json→packageManager: pnpm@10.19.0(must be an OIDC-capable version; can't stay at 10.5.2).version:pin from bothrelease-please.ymlandci.yml, soaction-setupderives the version frompackageManager.Verified locally: corepack switches to 10.19.0 and
pnpm install --frozen-lockfileresolves cleanly against the existing lockfile (same pnpm 10.x lockfile format).Follow-up
@ambosstech/core@0.1.1was tagged by release-please but never published (this is the run that failed), so it's a skipped version on npm. Once this lands, the next release will publish through the corrected workflow.