fix(textUtils): Emit Auto-link target/rel via Mdast #794
Open
Xavier-Charles wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
remarkRegexplugin intextUtils.tsxattacheshPropertiesto thelink node's
valuefield. mdast-util-to-hast (used by react-markdown) onlyreads
hPropertiesfrom a node'sdatafield, so the properties weresilently dropped — every auto-linked URL lost its
target="_blank"andrel="noopener noreferrer"attributes.This is both:
and lost the
noopenerprotection, andremarkRegex()snapshot test.The attributes were placed under
valueonly to satisfy theIParentWithLiteralinterface (which required avalue), so the type shapewas masking the real bug.
Fix
hPropertiesfromvalue→data(the correct mdast field).IParentWithLiteralso link nodes aren't forced to carryvalue.Verification
textUtils.test.tsThe remaining 12 failures are pre-existing environmental issues (Web Share
API, ResizeObserver, redux store, firebase script loading) unrelated to this
change.