Skip to content

extract_frontend_assets output errors, and probably hard failure is a better default #104

Description

@davecoates

Update extract_frontend_assets (and the new version in #65) to output, or have the option to output, the specific TemplateSyntaxError that is causing failures

Also I think having the default case be to fail a build if this happens, otherwise you run the risk of production build missing files. This is a change on the template project end.

Turns out I already had done that: https://gitlab.internal.alliancesoftware.com.au/alliance/template-django/-/merge_requests/562/diffs

Other template changes:

Consider how to make VITE_BUNDLER_MODE more intuitive. e.g. you have to have VITE_BUNDLER_MODE=development in order to build the files, because the mode just means how it's going to resolve assets. In order to build the files it needs to resolve them in file system etc. "production" means use the built files, e.g. resolve them from the manifest.json file.

The MR above also sets the env var in the build itself which is probably much more sensible, otherwise you have to set it in CI and know what to set it to if running builds in other places

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions