Add RSA CBC cipher suites for older Axis cameras - #2383
Open
blineadam wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Older Axis cameras fail to connect over
httpxwithremote error: tls: handshake failure. Seen on an Axis M5054 running firmware 6.53.4; cameras on the current AXIS OS 12 firmware are not affected, this is specific to older firmware and camera generations.That firmware negotiates TLS 1.2 but offers no ECDHE support and no GCM suites, so it shares nothing with the current
insecureConfiglist. Probing the camera withopenssl s_clientshows every ECDHE suite rejected (alert 40),AES128-GCM-SHA256/AES256-GCM-SHA384rejected, and only RSA-key-exchange or DHE CBC suites accepted (DHE-RSA-AES256-SHA,AES256-SHA). Go's crypto/tls has no DHE support, which leaves the RSA CBC pair as the only route.This adds
TLS_RSA_WITH_AES_128_CBC_SHAandTLS_RSA_WITH_AES_256_CBC_SHAto the list, the same situation #1172 fixed for cameras that need the RSA GCM suites. SinceinsecureConfigalready skips certificate verification for self-signed devices, offering two more legacy suites does not meaningfully change its security posture.Tested against the M5054: without this change the fetch fails with the handshake error above; with it,
httpx://user:pass@camera/axis-cgi/mjpg/video.cgistreams normally.