Update pion/dtls and pion/stun to patch known advisories - #2382
Open
paolostivanin wants to merge 1 commit into
Open
Update pion/dtls and pion/stun to patch known advisories#2382paolostivanin wants to merge 1 commit into
paolostivanin wants to merge 1 commit into
Conversation
pion/dtls v3.0.10 -> v3.1.5 GHSA-wg4g-wm44-ch5j / CVE-2026-54908 - remote DoS, panic while parsing a crafted ECDHE_PSK ServerKeyExchange (fixed in v3.1.4) GHSA-9f3f-wv7r-qc8r / CVE-2026-26014 - AES-GCM random nonce generation risks leaking the authentication key (fixed in v3.1.1) pion/stun v3.1.1 -> v3.1.6 GHSA-34rh-wp3j-6cxc - remote DoS, panic while parsing a malformed XOR-MAPPED-ADDRESS attribute (fixed in v3.1.5) Both sit on the WebRTC server path. go2rtc answers setup:active, so it acts as the DTLS client and does parse ServerKeyExchange from the peer, and the STUN attribute parser handles messages on the ICE port. Pulled in transitively by the above: pion/transport v4.0.1 -> v4.0.2, golang.org/x/crypto v0.47.0 -> v0.48.0, golang.org/x/sys v0.40.0 -> v0.41.0. go build ./... passes and the pkg/webrtc and internal/webrtc tests pass. The remaining ./... failures (pkg/core, pkg/hap/*, internal/ffmpeg) are identical before and after this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both packages have published advisories that are reachable from the WebRTC path.
pion/dtlsv3.0.10 -> v3.1.5ECDHE_PSKServerKeyExchangepion/stunv3.1.1 -> v3.1.6XOR-MAPPED-ADDRESSattributeReachability
go2rtc answers
a=setup:active, so it is the DTLS client and does parseServerKeyExchangefromthe peer. The STUN attribute parser handles messages arriving on the ICE port. Both are exposed to
whatever can reach the WebRTC listener, which for anyone who has forwarded 8555 is the internet.
Transitive updates
Pulled in by the two above, nothing requested directly:
pion/transport/v4v4.0.1 -> v4.0.2golang.org/x/cryptov0.47.0 -> v0.48.0golang.org/x/sysv0.40.0 -> v0.41.0Verification
go build ./...passes.go test ./pkg/webrtc/... ./internal/webrtc/...passes../...failures (pkg/core,pkg/hap/camera,pkg/hap/hds,pkg/ivideon,pkg/tuya,internal/ffmpeg) were re-run on the base commit with these changes stashed and areidentical before and after - they are pre-existing, not caused by this bump.