Skip to content

hardware: bind vaapi filter device for FFmpeg 8 #2374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kugaevsky wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −2
Open

hardware: bind vaapi filter device for FFmpeg 8 #2374

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions internal/ffmpeg/hardware/hardware.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,11 @@ func MakeHardware(args *ffmpeg.Args, engine string, defaults map[string]string)
args.Codecs[i] = defaults[name+"/"+engine]

if !args.HasFilters("drawtext=") {
args.Input = "-hwaccel vaapi -hwaccel_output_format vaapi -hwaccel_flags allow_profile_mismatch " + args.Input
// `-init_hw_device`/`-filter_hw_device` - bind a device to the
// filter graph, so `hwupload` works when the input isn't
// hardware decoded. Required since FFmpeg 8, which no longer
// derives the filter device from `-hwaccel` alone.
args.Input = "-init_hw_device vaapi=vaapi0 -filter_hw_device vaapi0 -hwaccel vaapi -hwaccel_output_format vaapi -hwaccel_flags allow_profile_mismatch " + args.Input

if name == "h264" {
fixPixelFormat(args)
Expand All @@ -82,7 +86,7 @@ func MakeHardware(args *ffmpeg.Args, engine string, defaults map[string]string)
args.InsertFilter("format=vaapi|nv12,hwupload")
} else {
// enable software pixel for drawtext, scale and transpose
args.Input = "-hwaccel vaapi -hwaccel_output_format nv12 -hwaccel_flags allow_profile_mismatch " + args.Input
args.Input = "-init_hw_device vaapi=vaapi0 -filter_hw_device vaapi0 -hwaccel vaapi -hwaccel_output_format nv12 -hwaccel_flags allow_profile_mismatch " + args.Input

args.AddFilter("hwupload")
}
Expand Down