fix: USR1/USR2 handling on OpenBSD#4992
Open
VlkrS wants to merge 4 commits intoAlexays:masterfrom
Open
Conversation
VlkrS
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately one part of #4278 introduced a bug that breaks USR1/USR2 handling for OpenBSD by treating them the same as SIGRT*
Instead of redefining SIGRTMIN and SIGRTMAX (which do not exist on OpenBSD), I would like to propose to only include the code sections that make use of those signals when SIGRTMIN is defined.
This will also make it explicit for those maintaining the OpenBSD port, when a feature is added or modified that makes use of those signals and that accordingly may need to be disabled or worked around on OpenBSD.
Thank you in advance for considering.
Cc: @rwsalie