Force title bar redraw on Windows 10 when applying the "dark", "light", or "normal" styles and some tkinter window detection improvements#47
Open
Valer100 wants to merge 1 commit into
Conversation
…", or "normal" style and call `update()` when getting a tkinter window's handle only if the window isn't realized
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue on Windows 10 when the title bar isn't redrawing after applying the "dark", "light", or "normal" styles without resizing the window, changing its transparency, hiding and showing it again, etc... For fixing this, I'm toggling the window's nonclient area focus by sending the
WM_NCACTIVATEmessage to the window and this forces the title bar to redraw without any problem.I've also improved the hwnd retrieval process for tkinter windows to just call
update()when the window isn't realized yet (after it's realized, callingupdate()is no longer needed and we can still get it's hwnd).