Adding in option to disable double click on previews - #2421
Open
Pauan wants to merge 3 commits into
Open
Conversation
Acly
reviewed
Apr 10, 2026
| def apply_result(self, item: QListWidgetItem): | ||
| job_id, index = self._history.item_info(item) | ||
| self.model.apply_generated_result(job_id, index) | ||
| if settings.preview_double_click_apply: |
Owner
There was a problem hiding this comment.
Haven't tested it, but this looks like it would prevent applying an image completely, not just via double click, but also the apply button
Instead the conditional should be at the point where the handler is registered, ie. in HistoryWidget.__init__ where it says self.itemDoubleClicked
Owner
|
We can keep the setting, but I'd prefer no UI for now. I don't think it's super vital and the interface settings easily become cluttered. Remove the translation strings and UI modification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents accidentally applying an image.
Defaults to true, so this doesn't change existing behavior.
Fixes #2293