Conversation
Contributor
|
Do we want to clear |
Contributor
|
@DataTriny Can you please add a comment in the winit examples explaining the reason for the announcement delay? |
mwcampbell
approved these changes
Apr 20, 2026
Contributor
mwcampbell
left a comment
mwcampbell
left a comment
There was a problem hiding this comment.
This is a good, thorough implementation of phase 1. The delay isn't ideal, but the better solution, if there is one, isn't obvious, so I won't block on that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 1 of #565
Implements the adapter for iOS and other Apple systems that use the UIKit runtime.
The adapter comes in two flavours: a low-level adapter suitable when the user owns the UIView and a subclassing adapter useful when integrating with third-party libraries that don't let the user manipulate the UIView, such as winit.
This first version is able to expose simple widgets like labels, buttons, checkboxes, switches, sliders... Live regions are also supported.
Necessary infrastructure is in place to run tests on a simulator, the CI is modified to take advantage of this and run the unit tests.
accesskit_winit now use the iOS subclassing adapter on appropriate targets. The examples have been modified and can be used to manually test the adapter.
The Slint toolkit is already compatible and its Gallery example can be used for further manual testing, although issues in its layout make VoiceOver refuse to focus certain widgets. Please use this branch where the AccessKit crates are patched.
Editable text is not yet implemented and focusing such a widget can confuse VoiceOver, depending on how the view is set up.