Skip to content

[refactor] small tweaks#291

Merged
antond-weta merged 1 commit into
AcademySoftwareFoundation:mainfrom
antond-weta:small_tweaks
May 26, 2026
Merged

[refactor] small tweaks#291
antond-weta merged 1 commit into
AcademySoftwareFoundation:mainfrom
antond-weta:small_tweaks

Conversation

@antond-weta

Copy link
Copy Markdown
Contributor

Description

A bit of cleanup in the cmake files, mostly to remove the unnecessary steps.

Tests

Checklist:

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable. (Check if there is no
    need to update the documentation, for example if this is a bug fix that
    doesn't change the API.)
  • I have ensured that the change is tested somewhere in the testsuite
    (adding new test cases if necessary).
  • My code follows the prevailing code style of this project. If I haven't
    already run clang-format before submitting, I definitely will look at the CI
    test that runs clang-format and fix anything that it highlights as being
    nonconforming.

Signed-off-by: Anton Dukhovnikov <antond@wetafx.co.nz>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.32%. Comparing base (a17901e) to head (52a293a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #291   +/-   ##
=======================================
  Coverage   91.32%   91.32%           
=======================================
  Files          17       17           
  Lines        3551     3551           
  Branches      527      527           
=======================================
  Hits         3243     3243           
  Misses        308      308           
Files with missing lines Coverage Δ
src/rawtoaces/main.cpp 100.00% <100.00%> (ø)
src/rawtoaces_core/rawtoaces_core.cpp 98.38% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a17901e...52a293a. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@soswow soswow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@antond-weta antond-weta merged commit ef9d3a7 into AcademySoftwareFoundation:main May 26, 2026
23 checks passed
@antond-weta antond-weta deleted the small_tweaks branch May 26, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants