Skip to content

Ensure that the tests find the built python module vs an install #4411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kdt3rd wants to merge 3 commits into
base: main
Choose a base branch
from
+22 −2
Open

Ensure that the tests find the built python module vs an install #4411

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04848f0
Ensure that the tests find the built python python module vs an insta…
kdt3rd Sep 8, 2024
4e08f52
Use generator expression to get correct OS separator
kdt3rd Sep 14, 2024
1340c90
Make build tree look more like install tree
kdt3rd Sep 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/cmake/testing.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ macro (oiio_add_tests)
"OIIO_TESTSUITE_ROOT=${_testsuite}"
"OIIO_TESTSUITE_SRC=${_testsrcdir}"
"OIIO_TESTSUITE_CUR=${_testdir}"
"PYTHONPATH=${CMAKE_BINARY_DIR}/lib/python/site-packages:$ENV{PYTHONPATH}"
Copy link
Copy Markdown
Collaborator

@lgritz lgritz Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the fact that you used : here account for the Windows CI failures?

Copy link
Copy Markdown
Contributor Author

@kdt3rd kdt3rd Sep 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most likely, switching to use generator expression which should be fine in cmake 3.14+ - the pathListSep config variable is not available until 3.24 or somesuch

${_ats_ENVIRONMENT})
if (NOT ${_ats_testdir} STREQUAL "")
set_property(TEST ${_testname} APPEND PROPERTY ENVIRONMENT
Expand Down