Add Token Factory integration - #11
Draft
Kayanski wants to merge 8 commits into
Draft
Conversation
Buckram123
approved these changes
Jan 8, 2025
Buckram123
left a comment
Buckram123
left a comment
There was a problem hiding this comment.
Nice. Couldn't find explanation why protobuf types copied instead of using osmosis-std (please add module-level comment)
| bail!("Subdenom {subdenom} by sender {sender} doesn't exist") | ||
| } | ||
|
|
||
| // We mint. No need for transactional cache here, if this fails, the tokenfactory mint fails |
There was a problem hiding this comment.
Suggested change
| // We mint. No need for transactional cache here, if this fails, the tokenfactory mint fails | |
| // We burn. No need for transactional cache here, if this fails, the tokenfactory burn fails |
typo
Author
I copied, because i don't want to bring osmosis-std here it's soooooo heavy ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds token factory capabilites into cw-multi-test.
For now the 3 following messages are handled for Osmosis :
MsgCreateDenom
MsgMint
MsgBurn
TODO :
Implement queries (is it needed ?)
Implement other tokenfactory flavors (neutron and xion have the same flavor)