Fix: comma-separated port declarations only process first port#61
Open
vjdeshmukh wants to merge 2 commits intoAUCOHL:mainfrom
Open
Fix: comma-separated port declarations only process first port#61vjdeshmukh wants to merge 2 commits intoAUCOHL:mainfrom
vjdeshmukh wants to merge 2 commits intoAUCOHL:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
When a Verilog module declares multiple ports on a single line (e.g.
input A, B;), the tool only classifies the first port and silently ignores the rest. This causes a misleading crash: "Some ports are not properly declared as an input or output" — even though the Verilog is perfectly valid.Cause
In Module.swift, the code assumed each Decl node contains only one port declaration, always taking list[0] and ignoring any remaining items in the list.
Fix
Replace list[0] with a loop over all items in the list, so every port in a comma-separated declaration gets processed.
Impact
This bug causes fault to crash on any standard Verilog file that uses comma-separated port declarations (e.g.
input A, B;), which is common in real-world netlists. This includes the ISCAS-89 benchmark suite where all 39 files use this style, making the entire sequential circuit benchmark suite unusable.