feat(actions/execution_environments): use first valid proxy with Ansi…#95
Open
sbernhard wants to merge 2 commits into
Open
feat(actions/execution_environments): use first valid proxy with Ansi…#95sbernhard wants to merge 2 commits into
sbernhard wants to merge 2 commits into
Conversation
sbernhard
force-pushed
the
use_first_valid_proxy
branch
2 times, most recently
from
dc139e0 to
c137d32
Compare
…ble_Director feature Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
sbernhard
force-pushed
the
use_first_valid_proxy
branch
2 times, most recently
from
01e384d to
12d0be8
Compare
…ct org Before this commit, the Smart Proxy was chosen no matter which user from which organization runs the action. After this commit, the correct smart proxy for this user/org is used and then passed throw to the actions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
sbernhard
force-pushed
the
use_first_valid_proxy
branch
from
12d0be8 to
cecbbd2
Compare
Contributor
|
I think that at least this one is missing: https://github.com/ATIX-AG/foreman_ansible_director/blob/main/app/services/foreman_ansible_director/pulp3/base_client.rb#L10 |
Contributor
Or maybe not: #89 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ble_Director feature