feat(ui): require organization selection before entering pages by Thorben-D · Pull Request #63 · ATIX-AG/foreman_ansible_director

Thorben-D · 2026-04-15T15:38:13Z

Before this commit, the "Content", "Execution Environment" and "Environments" pages would load incorrectly, if the user had selected "Any Organization".
Management of these objects across organizations is currently not supported.

To ensure the user has selected an organization, a new component, "ForceTaxonomy", is introduced, which requires the user to select an organization before proceeding.

The ForceTaxonomy component is generalized and supports enforcement of:

Organization selection
Loction selection
Organization and Location selection

Now, to access the "Content", "Execution Environments" and "Environments" pages, the user has to have a concrete organization selected.

Screenshots:

For illustration of the location requirement ability, not currently used:

Before this commit, the "Content", "Execution Environment" and "Environments" pages would load incorrectly, if the user had selected "Any Organization". Management of these objects across organizations is currently not supported. To ensure the user has selected an organization, a new component, "ForceTaxonomy", is introduced, which requires the user to select an organization before proceeding. The ForceTaxonomy component is generalized and supports enforcement of: - Organization selection - Loction selection - Organization and Location selection Now, to access the "Content", "Execution Environments" and "Environments" pages, the user has to have a concrete organization selected.

sbernhard · 2026-04-15T15:46:05Z

I would prefer to re-use something from foreman. Is there already somthing like this available? Or can you send a PR to foreman to add such a component (without Typescript as they are using React only)

Thorben-D · 2026-04-16T06:18:35Z

I would prefer to re-use something from foreman. Is there already somthing like this available? Or can you send a PR to foreman to add such a component (without Typescript as they are using React only)

Unfortunately, such a thing does not currently exist in Foreman. The Katello implementation is written in Angular, and can't be reused.
I'm not sure there is a usecase for this in Foreman, given that it wasn't needed so far.

sbernhard · 2026-04-16T06:23:56Z

Unfortunately, such a thing does not currently exist in Foreman. The Katello implementation is written in Angular, and can't be reused. I'm not sure there is a usecase for this in Foreman, given that it wasn't needed so far.

Can you reach out to Ian and/or Maria to clarify if there is a need for this? Would be easier for everyone to have one component which can be re-used in plugins - and then I think, its necessary to have it Foreman itself.

Thorben-D · 2026-04-16T06:30:43Z

I can, but that is out of scope for this PR.
As long as Katello uses Angular, they won't need this, as this implementation can not be used with Angular.

sbernhard · 2026-04-16T06:41:06Z

As long as Katello uses Angular, they won't need this, as this implementation can not be used with Angular.

Katello is currently moving forward with the transition to React.

See:
https://community.theforeman.org/t/ui-plan-transitioning-from-pf3-erb-and-angular-to-patternfly-6/45946/9
Katello/katello#11693 (and there is more)

nadjaheitmann

I could not test the location part but the organization part works as expected.

nadjaheitmann · 2026-04-17T11:19:39Z

+          addToast({
+            type: 'success',
+            key: `UPDATE_CURRENT_${type.toUpperCase()}_SUCC`,
+            message: `Successfully updated the current ${type}!`,


The message needs a translation.

nadjaheitmann · 2026-04-17T11:19:51Z

+          addToast({
+            type: 'danger',
+            key: `UPDATE_CURRENT_${type.toUpperCase()}_ERR`,
+            message: `Updating the current ${type} failed with error code "${


The message needs a translation.

maximiliankolb · 2026-04-22T13:46:37Z

Looks like there's already some code duplication on HEAD of "main" too:

$ rg addToast | wc
     60     184    7404

$ rg -A 3 addToast
webpack/components/ansible_execution_environments/components/ExecutionEnvGridWrapper.tsx
13:import { addToast } from 'foremanReact/components/ToastsList';
14-import { translate as _ } from 'foremanReact/common/I18n';
15-
16-import { useDispatch } from 'react-redux';
--
99:          addToast({
100-            type: 'success',
101-            key: `DESTROY_EE_${selectedEnv.name}_SUCC`,
102-            message: `Successfully deleted Ansible Execution Environment "${selectedEnv.name}"!`,
--
109:          addToast({
110-            type: 'danger',
111-            key: `DESTROY_EE_${selectedEnv.name}_ERR`,
112-            message: `Deletion of Ansible Execution Environment "${
--
141:          addToast({
142-            type: 'success',
143-            key: `UPDATE_EE_${selectedEnv.name}_SUCC`,
144-            message: `Successfully updated Ansible Execution Environment "${selectedEnv.name}"!`,
--
150:          addToast({
151-            type: 'danger',
152-            key: `UPDATE_EE_${selectedEnv.name}_ERR`,
153-            message: `Updating of Ansible Execution Environment "${
--
181:        addToast({
182-          type: 'success',
183-          key: `CREATE_EE_${env.name}_SUCC`,
184-          message: `Successfully created Ansible Execution Environment "${env.name}"!`,
--
191:        addToast({
192-          type: 'danger',
193-          key: `CREATE_EE_${env.name}_ERR`,
194-          message: `Creation of Ansible Execution Environment "${
...

maximiliankolb · 2026-04-22T13:57:23Z

+        <CardTitle>
+          <TextContent>
+            <Text component={TextVariants.h2}>
+              {_('An organization is required to proceed.')}


Suggested change

{_('An organization is required to proceed.')}

{_('Select an organization.')}

Please check if all of those texts end with a dot or not.

Same suggestion applies to line 173 and 131.

nadjaheitmann · 2026-05-07T07:19:44Z

Looks like there's already some code duplication on HEAD of "main" too:

$ rg addToast | wc
     60     184    7404

$ rg -A 3 addToast
webpack/components/ansible_execution_environments/components/ExecutionEnvGridWrapper.tsx
13:import { addToast } from 'foremanReact/components/ToastsList';
14-import { translate as _ } from 'foremanReact/common/I18n';
15-
16-import { useDispatch } from 'react-redux';
--
99:          addToast({
100-            type: 'success',
101-            key: `DESTROY_EE_${selectedEnv.name}_SUCC`,
102-            message: `Successfully deleted Ansible Execution Environment "${selectedEnv.name}"!`,
--
109:          addToast({
110-            type: 'danger',
111-            key: `DESTROY_EE_${selectedEnv.name}_ERR`,
112-            message: `Deletion of Ansible Execution Environment "${
--
141:          addToast({
142-            type: 'success',
143-            key: `UPDATE_EE_${selectedEnv.name}_SUCC`,
144-            message: `Successfully updated Ansible Execution Environment "${selectedEnv.name}"!`,
--
150:          addToast({
151-            type: 'danger',
152-            key: `UPDATE_EE_${selectedEnv.name}_ERR`,
153-            message: `Updating of Ansible Execution Environment "${
--
181:        addToast({
182-          type: 'success',
183-          key: `CREATE_EE_${env.name}_SUCC`,
184-          message: `Successfully created Ansible Execution Environment "${env.name}"!`,
--
191:        addToast({
192-          type: 'danger',
193-          key: `CREATE_EE_${env.name}_ERR`,
194-          message: `Creation of Ansible Execution Environment "${
...

I don't see how you could improve that code much TBH.

nadjaheitmann · 2026-05-07T07:20:14Z

What is holding us back here except the strings?

nadjaheitmann reviewed Apr 17, 2026

View reviewed changes

maximiliankolb reviewed Apr 22, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ui): require organization selection before entering pages#63

feat(ui): require organization selection before entering pages#63
Thorben-D wants to merge 1 commit into
mainfrom
force_taxonomy

Thorben-D commented Apr 15, 2026

Uh oh!

sbernhard commented Apr 15, 2026

Uh oh!

Thorben-D commented Apr 16, 2026

Uh oh!

sbernhard commented Apr 16, 2026

Uh oh!

Thorben-D commented Apr 16, 2026

Uh oh!

sbernhard commented Apr 16, 2026

Uh oh!

nadjaheitmann left a comment •

edited

Loading

Uh oh!

nadjaheitmann Apr 17, 2026

Uh oh!

nadjaheitmann Apr 17, 2026

Uh oh!

maximiliankolb commented Apr 22, 2026

Uh oh!

maximiliankolb Apr 22, 2026

Uh oh!

nadjaheitmann commented May 7, 2026

Uh oh!

nadjaheitmann commented May 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	{_('An organization is required to proceed.')}
	{_('Select an organization.')}

Conversation

Thorben-D commented Apr 15, 2026

Uh oh!

sbernhard commented Apr 15, 2026

Uh oh!

Thorben-D commented Apr 16, 2026

Uh oh!

sbernhard commented Apr 16, 2026

Uh oh!

Thorben-D commented Apr 16, 2026

Uh oh!

sbernhard commented Apr 16, 2026

Uh oh!

nadjaheitmann left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nadjaheitmann Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

nadjaheitmann Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

maximiliankolb commented Apr 22, 2026

Uh oh!

maximiliankolb Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

nadjaheitmann commented May 7, 2026

Uh oh!

nadjaheitmann commented May 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nadjaheitmann left a comment •

edited

Loading