feat(ui/i18n): mark more missing strings for translation#39
Open
nadjaheitmann wants to merge 1 commit into
Open
feat(ui/i18n): mark more missing strings for translation#39nadjaheitmann wants to merge 1 commit into
nadjaheitmann wants to merge 1 commit into
Conversation
Member
|
Actually, I would prefer to have "__" as "translate" instead of "_". See https://github.com/theforeman/foreman/blob/develop/webpack/assets/javascripts/react_app/components/HostDetails/ActionsBar/actions.js#L4 AFAIK, this is currently not the case for this project. That said, I would vote to merge these. |
Contributor
Author
I had the same thought and I agree. But we need to work with the current project 'settings' as you said.
Please approve and let's merge it. |
nadjaheitmann
force-pushed
the
mark_strings_for_translations
branch
from
9ef6cf9 to
51e19f3
Compare
nadjaheitmann
force-pushed
the
mark_strings_for_translations
branch
3 times, most recently
from
079252e to
ca45631
Compare
nadjaheitmann
force-pushed
the
mark_strings_for_translations
branch
from
ca45631 to
9119f82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated-By Mistral Vibe AI
(This PR may not contain all the strings, some will be added with #35)