Prohibit nested roots

[tuancoltech]

Description:

Prohibit nested roots: #68

For the duplicated logic removal of RootPickerDialogFragment, or to be exact, FoldersViewModel, it should be done in Navigator repository.
An in-progress work is here: ARK-Builders/Navigator#441

Before

Screen.Recording.2024-10-29.at.22.25.00.mov

After

Screen.Recording.2024-10-29.at.22.23.17.mov

[mdrlzy]

Can you make second condition as separate variable?
Second condition is hard to understand, maybe root.startsWith(file) || file.startsWith(root)
startsWith checks if this is child of argument path

[mdrlzy]

Can you also extract this check as separate method to the utils module?
We will need this check in Navigator app.

[mdrlzy]

It seems you don't check if selected folder is parent of root.
We can't allow /Internal/Music root and /Internal/Music/A selected folder to pass

[tuancoltech]

@mdrlzy The changes in this PR are doing exactly what you think is missing.
That means, if /Internal/Music/A is root, pinning (in consequence, making root) /Internal/Music is disallowed.

[shubertm]

Why do we have to avoid making the parent folder root when a child is already root? I thought by nested it was meant that once a folder is made root every folder inside it cannot be made root again. By this definition a parent to that folder can be made root by dropping all the children that are roots within it (root means ark folder)
@kirillt @mdrlzy @tuancoltech @hieuwu

[mdrlzy]

Why do we have to avoid making the parent folder root when a child is already root? I thought by nested it was meant that once a folder is made root every folder inside it cannot be made root again. By this definition a parent to that folder can be made root by dropping all the children that are roots within it (root means ark folder) @kirillt @mdrlzy @tuancoltech @hieuwu

Good point. I think since we are moving core to JNI, transfer of root should be part of Rust ark-core api. It's easier to disallow it now.

[kirillt]

Later would be great to implement "moving the root up", i.e. marking a parent as root, which would automatically mark all chilren-roots as favorites. But this requires some manipulation with indexes. Yes, it will be implemented in Rust.

Right now, it's better to disable nested roots. Technically, we can allow them, it would just mean that same files are tracked by different indexes. But indexing these separate indexes (1 in parent and 1 in child) would be independent so it can lead to waste of time for users, when they open folder /A/B, then /A or /A/B/C. Favorite folders delegate indexing to its parent root, so better to explicit about it right now.

[shubertm]

Right now we are denying tracking files in /A when /A/B is root, right?

[tuancoltech]

Right now we are denying tracking files in /A when /A/B is root, right?

@shubertm Correct.

[shubertm]

Everything is good. Just resolve current comments please