-
-
Notifications
You must be signed in to change notification settings - Fork 615
Improve README wording and formatting #1045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,12 +1,13 @@ | ||||||
| # PictoPy | ||||||
|
|
||||||
| PictoPy is an advanced desktop gallery application that combines the power of Tauri, React, and Rust for the frontend with a Python backend for sophisticated image analysis and management. | ||||||
| PictoPy is an advanced desktop gallery application that combines the power of Tauri, React, and Rust on the frontend with a Python backend for sophisticated image analysis and management. | ||||||
|
|
||||||
| # Want to Contribute? 😄 | ||||||
|
|
||||||
| ## Want to Contribute? 😄 | ||||||
|
|
||||||
| <a href="https://discord.gg/hjUhu33uAn"><img src="https://github.com/user-attachments/assets/3ed93273-5055-4532-a524-87a337a4fbba" height="40"></a> | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Add alt text for accessibility. The Discord badge image is missing alt text, which prevents screen readers from conveying its purpose to visually impaired users. ♿ Proposed fix for accessibility- <a href="https://discord.gg/hjUhu33uAn"><img src="https://github.com/user-attachments/assets/3ed93273-5055-4532-a524-87a337a4fbba" height="40"></a>
+ <a href="https://discord.gg/hjUhu33uAn"><img src="https://github.com/user-attachments/assets/3ed93273-5055-4532-a524-87a337a4fbba" alt="Join our Discord server" height="40"></a>Based on static analysis hints. 📝 Committable suggestion
Suggested change
🧰 Tools🪛 markdownlint-cli2 (0.18.1)8-8: Images should have alternate text (alt text) (MD045, no-alt-text) 🤖 Prompt for AI Agents |
||||||
|
|
||||||
| 1. First, join the **[Discord Server](https://discord.gg/hjUhu33uAn) (Go to Projects->PictoPy)** to chat with everyone. | ||||||
| 1. First, join the **[Discord Server](https://discord.gg/hjUhu33uAn)** (Go to Projects → PictoPy) to chat with the community. | ||||||
| 2. For detailed setup instructions, coding guidelines, and the contribution process, please check out our [CONTRIBUTING.md](./CONTRIBUTING.md) file. | ||||||
|
|
||||||
| # Architecture | ||||||
|
|
@@ -17,7 +18,7 @@ PictoPy is an advanced desktop gallery application that combines the power of Ta | |||||
| - **React**: Used for creating the user interface | ||||||
| - **Rust**: Powers the backend, which the frontend communicates with through Tauri's API | ||||||
|
|
||||||
| ### Backend (Python) | ||||||
| ### Backend (Python - FastAPI) | ||||||
|
|
||||||
| - **FastAPI**: Serves as the API framework | ||||||
| - **SQLite**: Database for storing metadata and embeddings | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarify the frontend/backend architecture description.
The phrase "Tauri, React, and Rust on the frontend" is technically inaccurate. According to your architecture section (lines 15-32), Rust powers the Tauri backend layer, not the frontend. The frontend consists of the Tauri framework and React for UI.
Consider rewording for technical accuracy:
📝 Suggested rewording
📝 Committable suggestion
🤖 Prompt for AI Agents