Update protos for old test vectors and re-generate them.#155
Open
jwcullen wants to merge 1 commit into
Open
Conversation
jwcullen
commented
Feb 27, 2026
jwcullen
commented
Collaborator
- Old protos are stale and incompatible with comparison scripts.
- Update them, but the modern encoder loudness measurements vary. To keep metadata in sync also update the output files.
- Based on AOMediaCodec/iamf-tools@5beb827.
- Old protos are stale and incompatible with comparison scripts. - Update them, but the modern encoder loudness measurements vary. To keep metadata in sync also update the output files. - Based on AOMediaCodec/iamf-tools@5beb827.
felicialim
approved these changes
Mar 6, 2026
Collaborator
Author
|
These are just needed so the older test vectors can be used on the main branch. @yilun-zhangs |
|
@jwcullen The test vectors have been updated, Should the corresponding test files also be updated? |
Collaborator
Author
|
@jingbo-marquis, we changed how the metadata works to describe these for the v2 test vectors. Most of the changes here are just to sync the metadata, but the resultant test files are the same. A few have changed because they have different loudness measurements due to tweaks or bug-fixes. |
Yes, the loudness values for many test vectors have changed. To maintain consistency, the test files should also be updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.