Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testintel: add missing test for Decoder3d.forward (created by linxwang) #1097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
testintel: add missing test for Decoder3d.forward (created by linxwang) #1097
Changes from 13 commits
faf1ae8171123ea8b2030c58bd51a7c14cffb3db9440f74e0b3b68f96d74fb5207b44d8204f01bb2afaaa7805ce3bf4791719defaFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TestIntel PR Steward: Good catch — fixed in 8204f01 by passing
devices=[]totorch.random.fork_rng(), so the seeding scope no longer forks CUDA RNG state on GPU-enabled runners.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TestIntel PR Steward: Declining this one after checking the architecture in
vae2_2.py.Resample.forward(modeupsample3d) only performs the temporal 2x doubling inside theif feat_cache is not None:branch — whenfeat_cacheisNoneit falls through to spatial-only upsampling and the time dimension is left unchanged. So there isn't a "single-shot, no-cache" decode path in this model that reproduces the streamed result:WanVAE_.decodeitself always drivesDecoder3dframe-by-frame through a sharedfeat_cache/feat_idx, exactly like this test does. A full-sequence call with a fresh cache andfirst_chunk=Truealso isn't equivalent, since the temporal-upsample branch only skips doubling on the very first cache slot access regardless of how many frames are in that call, so it wouldn't reproduce the expected 5-frame streamed output either. Given that, the cache-bookkeeping + determinism assertions already in this PR are the correct/only feasible way to pin down this behavior; a "no-cache reference" comparison would just be comparing against a different, non-equivalent computation. Happy to revisit if you see a concrete construction that sidesteps this.