test: pin Wan CausalConv3d streaming cache (PRPUNDIT-24) - #1086
test: pin Wan CausalConv3d streaming cache (PRPUNDIT-24)#1086jiagaoxiang wants to merge 1 commit into
Conversation
PRPUNDIT-24 covers both vae2_1 and vae2_2 in one parameterized suite: chunked cache_x reuse versus a full-sequence pass, plus an independent F.pad + Conv3d oracle.
There was a problem hiding this comment.
🟢 Approval recommended
The change is isolated to a new test file and accurately exercises the existing CausalConv3d cache/padding behavior in both targeted modules.
Pull request overview
Adds a parameterized unit-test suite to pin CausalConv3d.forward streaming-cache behavior for both Wan 2.1 and Wan 2.2 VAE implementations, ensuring chunked streaming output matches a full-sequence pass and validating the cache-splice/front-padding arithmetic via an independent F.pad + F.conv3d oracle.
Changes:
- Introduces a single parameterized test module covering both
vae2_1.pyandvae2_2.pyCausalConv3dimplementations. - Validates full-sequence output against an independent padding+conv oracle and asserts expected causal padding layout.
- Verifies chunked streaming with cached frames (
CACHE_T) matches full-sequence output, including full/partial/no-temporal-padding cache cases.
File summaries
| File | Description |
|---|---|
tests/unit_tests/backends/diffusion/test_wan_vae_causal_conv3d.py |
New parameterized unit tests that pin causal temporal padding and streaming-cache equivalence across Wan 2.1 and 2.2 VAE modules. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
TestIntel PR Steward: Checked in on this PR after the poll flagged CI failure + a new review. CI — The Copilot review: recommended approval, 0 inline comments — nothing actionable to address. Still waiting on a human approval before this can merge; will keep watching. |
This PR was created by dougljia via Test Gap Resolver.
Summary
vae2_1.py::CausalConv3d.forwardand Wan 2.2vae2_2.py::CausalConv3d.forward.CACHE_Tframes of the previous chunk ascache_xand must match a single full-sequence pass; an independentF.pad+Conv3doracle pins the cache-splice / reduced-front-padding arithmetic.vae2_2.py).Closes test gap PRPUNDIT-24.
Test plan
PYTHONPATH=. pytest tests/unit_tests/backends/diffusion/test_wan_vae_causal_conv3d.py(12 passed, CPU: 6 tests × 2 VAE modules)black --checkon the new file