Update trampoline to use the official spec version - #688
Draft
t-bast wants to merge 5 commits into
Draft
Conversation
t-bast
force-pushed
the
trampoline-spec-version
branch
from
July 18, 2024 13:52
c7a69c3 to
3e8b0dc
Compare
t-bast
force-pushed
the
trampoline-spec-version
branch
from
August 9, 2024 10:02
3e8b0dc to
a5e3e16
Compare
t-bast
force-pushed
the
trampoline-spec-version
branch
from
September 18, 2024 21:02
2a1e84d to
b5764b0
Compare
t-bast
force-pushed
the
trampoline-spec-version
branch
2 times, most recently
from
October 23, 2024 05:34
6aeb170 to
c43d447
Compare
t-bast
force-pushed
the
trampoline-spec-version
branch
2 times, most recently
from
December 6, 2024 13:17
627c493 to
8ccb161
Compare
t-bast
force-pushed
the
trampoline-spec-version
branch
from
March 3, 2025 09:53
8ccb161 to
94974e7
Compare
t-bast
force-pushed
the
trampoline-spec-version
branch
from
April 2, 2025 09:32
94974e7 to
d6887f4
Compare
We update the trampoline feature to match the official specification from lightning/bolts#836. We remove support for the previous version of trampoline, which means that when paying nodes that use the experimental version, we will use the trampoline-to-non-trampoline flow instead. Similarly, when older nodes pay updated nodes, they won't understand the new trampoline feature bit and will use the trampoline-to-non-trampoline flow. We update the trampoline-to-non-trampoline flow to remove the unused trampoline payload in the onion, which saves some space. Note that we don't want to officially specify this scenario, as it leaks some data about the recipient to the trampoline node. We rather wait for nodes to either support trampoline or blinded paths, which fixes this issue.
We update our trampoline payments to blinded paths to match the official specification from lightning/bolts#836. The blinded paths and recipient features are included in the trampoline onion, which potentially allows using multiple trampoline hops. That was already what we were doing with experimental TLVs, so we simply update the TLV values to match the spec values.
We add the ability to pay recipients that support trampoline *and* blinded paths. We include the blinded path data in the trampoline payloads for each node inside the blinded path. This doesn't reveal unnecessary information to the trampoline node: this is specified in details in lightning/bolts#836.
Add support for the trampoline failure messages added to the BOLTs. We also add support for encrypting failures e2e using the trampoline shared secrets on top of the outer onion shared secrets.
When the recipient supports blinded trampoline payments and uses the same introduction node as our trampoline node, we mustn't add a hop from our trampoline node to itself: we can directly use them as the blinded path's trampoline introduction node. This is what payments between mobile wallets using the same trampoline node will look like.
t-bast
force-pushed
the
trampoline-spec-version
branch
from
August 28, 2026 13:01
d6887f4 to
89ca3af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We update our trampoline code to use the official values from the BOLTs. Note that we don't maintain backwards-compatibility with the experimental trampoline feature bit and types, which means that:
I think this is a good trade-off to avoid the technical debt and risks associated with maintaining two versions of trampoline in parallel.
Note that ACINQ/eclair#2819 must be deployed on the ACINQ node before merging this PR.