Repository navigation
Avoid CRAN CPU notes from Stan smoke test and example (#91) - #92
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
WestonVoglesonger
marked this pull request as ready for review
October 7, 2026 22:53
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
csmith701
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #91.
What changed
test-hestia-smoke.Rwhen testthat identifies a CRAN check. The package/data smoke assertion still runs there.NOT_CRAN=truein the coverage job so CI continues to execute the real one-chain fit and its draw assertions.run_model()example with@examplesIf interactive(), retaining its existing\\donttest{}block as required byAGENTS.md. This keeps the example available interactively and prevents noninteractive--run-donttestchecks from fitting four default chains at 2,000 iterations.No Stan model or numerical API changed.
Evidence
The October 6 Debian incoming pretest reports test CPU/elapsed near 30 s / 6 s (5.4×). On an isolated install of the exact candidate commit
3680e470on macOS R 4.5.3, the smoke-sized fit used 3.35 CPU seconds / 0.62 elapsed seconds. ExplicitSTAN_NUM_THREADS=1,OPENBLAS_NUM_THREADS=1,RcppParallel::setThreadOptions(numThreads=1), andstan_options(threading=TRUE, max_cores=1)did not reduce that ratio locally.A local
--as-crancheck after the smoke skip but before the example guard ran the default fit under--run-donttest, using 519 CPU seconds / 86 elapsed seconds. After the example guard, that step completed without a fit.Validation
NOT_CRAN=false: targeted smoke test passed, with the live fit skipped and the cheap assertion active.NOT_CRAN=true: targeted smoke test ran the live Stan fit and passed all draw assertions.R CMD build .: passed.R CMD check --as-cran --no-manual: installation, examples,--run-donttestexamples, and tests passed. Used_R_CHECK_FORCE_SUGGESTS_=falsebecausepatchworkis not installed here, and disabled remote incoming checks because sandbox DNS is unavailable. The remaining two warnings (missingcheckbashisms,qpdf) and two notes (clock verification, macOSxcrun_dbtemp file) are environment findings unrelated to this patch.air format . --check,lintr::lint_package(), andgit diff --check: passed.Still to verify: Debian's CPU/elapsed check on the patched package. The PR CI matrix and coverage job will provide the next Linux validation; a CRAN incoming pretest remains the authoritative confirmation.