Repository navigation
Declare rprojroot dependency and update spelling wordlist - #86
Merged
Merged
Conversation
Declare rprojroot in Suggests (used via :: in test-rcpp_exports.R but never declared, tripping CRAN's "unstated dependencies in tests" check) and add a matching skip_if_not_installed() guard for consistency with the file's other soft dependencies. Also add four legitimate words (Analytics, Perrin, finiteness, reachability) that spelling::spell_check_test() flagged as potential misspellings during a real (NOT_CRAN=true) check run to inst/WORDLIST. All four are genuine: an org-name word, the maintainer's own name, and two ordinary technical English words absent from the default dictionary. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
pearsonca
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rprojrootinSuggests(DESCRIPTION) and add a matchingskip_if_not_installed()guard intests/testthat/test-rcpp_exports.R. The package was referenced via::in that test but never declared, which CRAN's "checking for unstated dependencies in tests" check correctly flags as a WARNING.Analytics,Perrin,finiteness,reachability) toinst/WORDLIST. These were flagged byspelling::spell_check_test()during a real (NOT_CRAN=true) check run — an org-name word, the maintainer's own name, and two ordinary technical English terms missing from the default dictionary, not actual typos.Test plan
spelling::spell_check_package(".", vignettes = TRUE)locally: "No spelling errors found."spelling::update_wordlist()was not used to regenerate the wordlist wholesale — it also dropped 19 previously-necessary entries (Bayesian,HMM,Rcpp,Stan, etc.), likely due to a hunspell dictionary version/platform mismatch between local Windows and CI's Ubuntu runners. The fix here is a minimal, additive edit instead.spelling.RNOTE no longer appear.🤖 Generated with Claude Code